From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle DW_AT_ranges when reading partial symtabs
Date: Mon, 01 Apr 2019 16:28:00 -0000 [thread overview]
Message-ID: <87ef6l8zcc.fsf@tromey.com> (raw)
In-Reply-To: <42d48bb2f79941b8fd646c7089492907@polymtl.ca> (Simon Marchi's message of "Fri, 29 Mar 2019 18:01:52 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> To help readability, I'd suggest adding some empty lines in there,
Simon> between each pair of lassign+set statements. At first it looked like
Simon> a bit cryptic blob to me until I split it in smaller pieces.
Thanks, I made this change.
Tom
prev parent reply other threads:[~2019-04-01 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 20:00 Tom Tromey
2019-03-29 22:02 ` Simon Marchi
2019-04-01 16:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef6l8zcc.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox