From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155099-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 60480 invoked by alias); 1 Apr 2019 16:28:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 60463 invoked by uid 89); 1 Apr 2019 16:28:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=Simon, Marchi, H*F:U*tromey, HX-Envelope-From:sk:tromey@
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Apr 2019 16:28:07 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 14C87117008;	Mon,  1 Apr 2019 12:28:05 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id C-i3PizAvHR0; Mon,  1 Apr 2019 12:28:05 -0400 (EDT)
Received: from murgatroyd (174-29-37-56.hlrn.qwest.net [174.29.37.56])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by rock.gnat.com (Postfix) with ESMTPSA id 8A60F116D75;	Mon,  1 Apr 2019 12:28:04 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle DW_AT_ranges when reading partial symtabs
References: <20190329200030.8368-1-tromey@adacore.com>	<42d48bb2f79941b8fd646c7089492907@polymtl.ca>
Date: Mon, 01 Apr 2019 16:28:00 -0000
In-Reply-To: <42d48bb2f79941b8fd646c7089492907@polymtl.ca> (Simon Marchi's	message of "Fri, 29 Mar 2019 18:01:52 -0400")
Message-ID: <87ef6l8zcc.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-04/txt/msg00004.txt.bz2

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> To help readability, I'd suggest adding some empty lines in there,
Simon> between each pair of lassign+set statements.  At first it looked like
Simon> a bit cryptic blob to me until I split it in smaller pieces.

Thanks, I made this change.

Tom