From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Handle PS1 quirk in gdb.base/multi-line-starts-subshell.exp
Date: Mon, 14 Dec 2020 08:47:30 -0700 [thread overview]
Message-ID: <87eejscru5.fsf@tromey.com> (raw)
In-Reply-To: <20201214065505.GA3249@delia> (Tom de Vries's message of "Mon, 14 Dec 2020 07:55:07 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> The problem is that the PS1 setting has no effect.
Why is that?
Tom> Fix this by setting PS1 after spawning the subshell.
Tom> Tested on x86_64-linux.
Tom> Any comments?
It seems fine but it may be good to understand why it is needed and
perhaps add a comment explaining it.
Tom
next prev parent reply other threads:[~2020-12-14 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 6:55 Tom de Vries
2020-12-14 15:47 ` Tom Tromey [this message]
2020-12-14 23:50 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eejscru5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox