From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0pn+HhiJ119LYgAAWB0awg (envelope-from ) for ; Mon, 14 Dec 2020 10:47:36 -0500 Received: by simark.ca (Postfix, from userid 112) id 721B71F0AA; Mon, 14 Dec 2020 10:47:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8A271E99A for ; Mon, 14 Dec 2020 10:47:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3816A3854815; Mon, 14 Dec 2020 15:47:35 +0000 (GMT) Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.156]) by sourceware.org (Postfix) with ESMTPS id 0C1CF3854815 for ; Mon, 14 Dec 2020 15:47:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C1CF3854815 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 74E7B577E for ; Mon, 14 Dec 2020 09:47:31 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oq4RkRpeZoE4Doq4Rku9ba; Mon, 14 Dec 2020 09:47:31 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dqtABLz+5UZuM/ban4CD/pqBuDarnTOrzMlXE08PFW4=; b=MPU6tpWHbFZ0/nJ8qhjs9TVG+M aeO3dQa3Vn8TyE1Z7Cb9miOTovvJ4WfjCgvLpJZjgEqivxC4GVka8lrnBoInrabrmLKmxcTAtwbNa N2OnBPxs10tmD8CjMFGkdMDlP; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:44290 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1koq4R-0027Op-3D; Mon, 14 Dec 2020 08:47:31 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/testsuite] Handle PS1 quirk in gdb.base/multi-line-starts-subshell.exp References: <20201214065505.GA3249@delia> X-Attribution: Tom Date: Mon, 14 Dec 2020 08:47:30 -0700 In-Reply-To: <20201214065505.GA3249@delia> (Tom de Vries's message of "Mon, 14 Dec 2020 07:55:07 +0100") Message-ID: <87eejscru5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1koq4R-0027Op-3D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:44290 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> The problem is that the PS1 setting has no effect. Why is that? Tom> Fix this by setting PS1 after spawning the subshell. Tom> Tested on x86_64-linux. Tom> Any comments? It seems fine but it may be good to understand why it is needed and perhaps add a comment explaining it. Tom