Re: [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU

[Tom Tromey <tom@tromey.com>]

>>>>> "Dmitry" == Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:

Thank you for your continued work on this.

Dmitry> +		      const language_defn *lang_def = language_def (entry->lang);
Dmitry> +		      lookup_name_info last_segment_lookup_name (
Dmitry> +			last_name.data (), symbol_name_match_type::FULL,
Dmitry> +			false, true);

Normally in gdb the open paren would go on the next line, like

> +		      lookup_name_info last_segment_lookup_name
> +			(last_name.data (), symbol_name_match_type::FULL,
> +			 false, true);

... depending on how long the lines are -- it would be split after some
',' if each line would then fit in 80 columns.

Dmitry> +		      symbol_name_matcher_ftype *name_matcher
Dmitry> +			= lang_def->get_symbol_name_matcher
Dmitry> +			  (last_segment_lookup_name);

This also looks weird by gdb rules.

Tom