From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id f2VBOBFfOmbhzAkAWB0awg (envelope-from ) for ; Tue, 07 May 2024 13:04:17 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=M4h+edrd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D50FF1E0C1; Tue, 7 May 2024 13:04:17 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6E6A1E092 for ; Tue, 7 May 2024 13:04:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E869F3845BC1 for ; Tue, 7 May 2024 17:04:14 +0000 (GMT) Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 22C043858D1E for ; Tue, 7 May 2024 17:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22C043858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 22C043858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715101438; cv=none; b=ZriB/6EWPuClc+asPqvjNe/VSwq9RBsO0cqHzl9xebnj/twbmRF8/kWJZ9ibSNZz92DPAcvgQ8ZMvYaQWe9FffC7skxsZs5YTski0cPSx/NCLlr7LSZxSjMBSZ5+cWcgf1/EJ9cQBR9BfbZ2vdbbEUSiT8j+F+3z0bet+02WEg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715101438; c=relaxed/simple; bh=nNkxeEgNSP2R3rTEZOBS23yI6PNXKEoOuRy9RDcN8ww=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RSG5bDQRKOHfijVBcKPTQ6sCcyw2p5aYCSChTWIAq4HLaZUWWE/CkuvFEMvZ5rUW6QtFGZ/MhS/QuNN1f5Q+vfys9ux9aoQwWf731n+YSPvOyerWbNMTw6AoyUTjztxmS99khAk2GHYedBmStCw3Xrspwp+sELFmD8Q64YAUAk4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id 4OBhsSWGLjfBA4OELsuVxL; Tue, 07 May 2024 17:03:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4OEKsIU5q9zHM4OELsmTSZ; Tue, 07 May 2024 17:03:53 +0000 X-Authority-Analysis: v=2.4 cv=fo4XZ04f c=1 sm=1 tr=0 ts=663a5ef9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=PqLztkmBgXuy2ECUEEoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gKwlpzwjJQ1qi2PT5n4HHJDkFFFKm5ZIZrZ4PWBOMbw=; b=M4h+edrdoxyt/vlOlafTlyYif+ zzr/bisH4CqFEDaW6JNrM3iG5byFG7P1DOVJa5PLqydeCyon6tzPXlbk8VCLbpyR+xFxtieNKrs3A ikUMeTnCHDRVqj7dnxXob/Nup; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:44628 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s4OEK-002gAs-1f; Tue, 07 May 2024 11:03:52 -0600 From: Tom Tromey To: Dmitry Neverov Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU In-Reply-To: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Mon, 6 May 2024 17:09:17 +0200") References: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> X-Attribution: Tom Date: Tue, 07 May 2024 11:03:51 -0600 Message-ID: <87edada70o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s4OEK-002gAs-1f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:44628 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGuwb6rYce5QQCCTZSVMf4FoR5jCb38aoAFcjUk/QW2OSollQqWxO3UDrnN08UULVCvY1VNvfWLg3WdDiDfSxbIfX1nogQX7qzZAugncUAs77BlEAZJ8 MSOhXjq29N+gr3B/gKJeo46g7e7inucIeqkHPW0lT8Y+eh7CEXm9ovF3phgBIZ9bkCic8qu8Sf3MAeUY2ut0Z8znbN9ntt1Icxs= X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Dmitry" == Dmitry Neverov writes: Thank you for your continued work on this. Dmitry> + const language_defn *lang_def = language_def (entry->lang); Dmitry> + lookup_name_info last_segment_lookup_name ( Dmitry> + last_name.data (), symbol_name_match_type::FULL, Dmitry> + false, true); Normally in gdb the open paren would go on the next line, like > + lookup_name_info last_segment_lookup_name > + (last_name.data (), symbol_name_match_type::FULL, > + false, true); ... depending on how long the lines are -- it would be split after some ',' if each line would then fit in 80 columns. Dmitry> + symbol_name_matcher_ftype *name_matcher Dmitry> + = lang_def->get_symbol_name_matcher Dmitry> + (last_segment_lookup_name); This also looks weird by gdb rules. Tom