From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes"
Date: Tue, 02 Dec 2025 10:41:43 -0700 [thread overview]
Message-ID: <87ecpc93xk.fsf@tromey.com> (raw)
In-Reply-To: <20251128134950.1763596-2-jan.vrany@labware.com> (Jan Vrany's message of "Fri, 28 Nov 2025 13:49:48 +0000")
>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:
Jan> Finally, I was considering of making this change up in lookup method
Jan> but in the end decided to be bit more conservative because comment in
Jan> original find_block_in_blockvector() suggested that returning a static
Jan> block from there is an expected situation.
FWIW it seems to me that the blockvector should just have a single
lookup function, and it should be used to find precisely the code block
containing the given address. That is, it should never return the
static or global block, since those aren't really "code" but instead
just containing scopes. This is the direction I was trying to head by
removing calls to map(); the one remaining call is one of these weird
ones...
Anyway I consider this important for supporting expandable blockvectors,
which in turn is important for lazy CU expansion.
Tom
next prev parent reply other threads:[~2025-12-02 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 13:49 [pushed] gdb: update blockvector::lookup Jan Vrany
2025-11-28 13:49 ` [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" Jan Vrany
2025-12-02 17:41 ` Tom Tromey [this message]
2025-12-02 21:58 ` Jan Vraný
2025-12-03 19:36 ` Tom Tromey
2025-12-03 21:31 ` Jan Vraný
2025-12-04 11:42 ` Tom de Vries
2025-12-04 15:03 ` Jan Vraný
2025-11-28 13:49 ` [pushed] gdb: add unittests for blockvector lookup functions Jan Vrany
2025-11-28 13:49 ` [pushed] gdb: update is_addr_in_objfile to support "dynamic" objfiles Jan Vrany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecpc93xk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox