From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uS/oAvwkL2nuHhEAWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 12:42:20 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YIw91fCc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 07A851E0B3; Tue, 02 Dec 2025 12:42:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CB361E08D for ; Tue, 02 Dec 2025 12:42:19 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 040AE4BBC093 for ; Tue, 2 Dec 2025 17:42:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 040AE4BBC093 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YIw91fCc Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 4BE3C4BA23F8 for ; Tue, 2 Dec 2025 17:41:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BE3C4BA23F8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4BE3C4BA23F8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764697307; cv=none; b=CpcMiKSaSOejoKsNcAbc+fBMcc032k302Nf75+E7/eWjAQGMbIgL+55UevVeS+F0tv9i7VquW7iOCl6adB8yc1iYT5UxINIUKRzxvdYhyThgddcwYFJSB1ZwoDnJZDWCgAv8KTu9v4WoR8dVYQuYRDsztAqWGAHOHJtlHoAGws8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764697307; c=relaxed/simple; bh=E2YKeAZBNOvskOR9AAlxJpvtP/uG8d1jOP6mGQAw2E4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k1Jr63fpiVDnvUC3V2StwEJwrRdZV0wEf/OO4eb3ZhJuIlFqBIH5HGH0iHevW/hvEh95EQYmRUIIb5dYmEFQNM1ud82YtR2Y74Diz74o/TawMxo8reraPrjnesT4oPlMjA/dE0+DO+3AbNxME8NklAL3QIlEz5hK8IK60f7XgSA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BE3C4BA23F8 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id QTCTvpKo8VCBNQUNmvrXvL; Tue, 02 Dec 2025 17:41:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QUNlv1aDwhoT4QUNmvfXpa; Tue, 02 Dec 2025 17:41:46 +0000 X-Authority-Analysis: v=2.4 cv=XZyJzJ55 c=1 sm=1 tr=0 ts=692f24da a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=f9ZHGnq8ln4lakXyS98A:9 a=4IKI_MBedZsHOhguCAbN:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nVAQxUkvVSlYQ6E/f8OCKIYnjOOlRL/UqvxX5AAMaK4=; b=YIw91fCcsnz0UnG/SSLUzDMPiC irVY/XpIwaFmC1nrLWdFA59/QWx+2O2tFThc0yy52DuVgOJ9Ui7hlQX1Hp1hwHAwNVzY0pRgFB6bG vPA7BTsxF1ARBUzXb4RX6lwjN; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:55894 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vQUNl-0000000276Y-26on; Tue, 02 Dec 2025 10:41:45 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" In-Reply-To: <20251128134950.1763596-2-jan.vrany@labware.com> (Jan Vrany's message of "Fri, 28 Nov 2025 13:49:48 +0000") References: <20251128134950.1763596-1-jan.vrany@labware.com> <20251128134950.1763596-2-jan.vrany@labware.com> X-Attribution: Tom Date: Tue, 02 Dec 2025 10:41:43 -0700 Message-ID: <87ecpc93xk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vQUNl-0000000276Y-26on X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:55894 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKgccxGXQ6gwmHo/lzYFFh4eT3r6ajsQxozFgmnDwxkK4dQ3XqQC0pICPN4w9nfqW9ueIaTaiDJVdwJmZf/oWoL/l/m0OTLSU21aRb4mX0r8b3YVCXx7 rSJuh1Q2/BdVwSxw7omEmq/qpzOoXATuNA4ubvl9k0XbcIAqx/aEerT/01DYmzjMWR9fSmMJrlvNzq5XZwlAU/2KyXQQCHuctCE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> Finally, I was considering of making this change up in lookup method Jan> but in the end decided to be bit more conservative because comment in Jan> original find_block_in_blockvector() suggested that returning a static Jan> block from there is an expected situation. FWIW it seems to me that the blockvector should just have a single lookup function, and it should be used to find precisely the code block containing the given address. That is, it should never return the static or global block, since those aren't really "code" but instead just containing scopes. This is the direction I was trying to head by removing calls to map(); the one remaining call is one of these weird ones... Anyway I consider this important for supporting expandable blockvectors, which in turn is important for lazy CU expansion. Tom