Re: [PATCH] Use fully-qualified name in var_decl_name

[Tom Tromey <tromey@adacore.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

>> This patch changes var_decl_name to use the correct full name for the
>> variable.

Andrew> I took a crack at writing a DWARF assembler test for this, which I've
Andrew> included below.

Andrew> I think it would be a good idea if a test was included with this patch.

Ok, I feel a little bad that you did this.  I didn't write a test for
the initial patch because I felt it was already covered by gnat-llvm
testing.

However I get that it's better to have a pure test for this.  Anyway
it's always fine to push back -- I would be fine writing a test.

So, thanks, and also sorry.

Andrew> Feel free to use what I've written, or change it as needed.  Or write
Andrew> your own if this isn't suitable.

Andrew> If the test below is OK, then:

I verified that the test fails without the patch and passes with it, and
also read the test & think it's fine.  So I'm including it.

Tom