From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ivlkK2fm9Gn7XgkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 13:44:07 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=g/GfPVPX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9F1F51E067; Fri, 01 May 2026 13:44:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D04381E067 for ; Fri, 01 May 2026 13:44:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 549374374203 for ; Fri, 1 May 2026 17:44:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 549374374203 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=g/GfPVPX Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id C30004BA2E12 for ; Fri, 1 May 2026 17:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C30004BA2E12 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C30004BA2E12 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777657422; cv=none; b=YtCmfNb10b81HFoRIsaxxnfngnyUhbHkS8Arh+2YFRRZaCNMAXDCAf3JC53t9TPbQp0Fii/Qvv2ADg/rroF/T3CBmboy/2kj61Ve8iJxJsjPESW+tCSBtStM2cgVhdClx3EhW+XSCf7mZlv+ZEyIlAozA8QwU+LH65v2Uy+Tz6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777657422; c=relaxed/simple; bh=+f1uPEb1qJDCOpzV3cMq6ZS1WsjBzdRjbYXJ+Lrk2ms=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vvbRyg+RxelGSd5Sk4kOdw/BdTotEkql0pKYxINRbCdouOpeap3fHs1rHLmyLSj9zjo6IcX/q7gxpQRn2Q4IgmBkXmTS2ZFKjLRVGr+hNcvVB2wlfrl2sbFaQe1dKrT72naAh41pvSu6MPgUSQBFY3wP/5Bkwv4xkEYHCpI2APU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C30004BA2E12 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-479d85152c9so818439b6e.2 for ; Fri, 01 May 2026 10:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1777657422; x=1778262222; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aUKVZhqodV+ii9Ckse1vow6mc25T83EbRbQE90hO7FQ=; b=g/GfPVPXpMuDi5yIDmoggPxnQ563jh2KdD3Eq7XaC26fg+AzshSYGO5x9WlA7c0X+X 8lPnF8DKwRfW54sowRAUVwelA/0DebimghQVy8c4JMx72v9+Oh7CAKVoYHeZ29JoEMLX J+MlPPmjXC1wxGrFjPjqPHSQQJEt6uFW4dNmpZo4+DrS5b03dgg/qWnN2j57lI5SRHOZ YZbfKF7X48VPNnoqLzsO2mF3Zc/AF3Jzg6tv26nxPLu48gFVHlNJ+q+GzhAZ0boiN/KI YYpKKFI+4xSkUQrdTeAHY79LjEI1hjpBn/fQPi9Q+VezhfsLEdJVGH8UTVrVu4a0+HDn vYYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777657422; x=1778262222; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aUKVZhqodV+ii9Ckse1vow6mc25T83EbRbQE90hO7FQ=; b=Y22XSVhatVlcQ6nQilnMzGjkmQiF6aEHKooE8iaosmd8fgYD+f4+opDXWp2LY0fkAW 0qy0eMQrGcp7HI8ddGfefpHu4xCPPNX5vVMPOAHaIp4++3OguybrAKugycNYJg8DsdIv PlZGix9eTiQxslRkr/lNdQQFV9KLzhKou5hrfiLulAU7pkRKL8HInh453xoBlVtE2dKh DmQsE29ScL3DGIdhSiX0tkY9RJPzQW5aG5yHbhBumZ8q8WRqJ6GgwUzdszJTXYJyPN/A jbpUTk7lITXSqeSF5EM21g77bkbDKi78KIKHsL6B2xC1pV0TBQj7re0RIp+P3UZOPV2A MM1Q== X-Forwarded-Encrypted: i=1; AFNElJ9OG6Ec6u46/Ju0HWlXjrFBP/5pOztf7+A8JJQUh2RhqGowqNklNk9/bJ15+qMTDv9r9onovJPSWkq5gw==@sourceware.org X-Gm-Message-State: AOJu0YyDUe5AMWMKdQ/CiPXk29Wcdl24cJFJTTA71tZhI6/LqnB/LTv9 Spmja9u63HgzWzhkbpq8cPa7bFaNRmirkKs0cO7iW7HVQFjEf4ve3eHGbeiyavXjjQ== X-Gm-Gg: AeBDievQdh6uFaJmFNZ0vqB202fgtsfIo7ltZBOMH27+Ain/D7m3VmEVZqXytA7eCR6 fPUfKi2KXQI2PAUqC9pXyrhZnGLyYgHJkuG8kZweVKgHw0UYBNhdZIc7rUTMvxxRzrXPJHGcYrX ppoDtnZOULQhTWSm4yyFdUKm3e8oGYHbQznGic6JBl9A1GHtPxg5kkIC26uynk6qbzMg4kuQ1AX 6MlSUXLj8CXow1z7n1sAQod9xV8OSwjtHw8FV3moT+NP2mu2mSR+9txVxAvasi/Bfu7m+X22+3i BxjaHzJA65EfN0cBNZMghFSW3sNIHI141uCOelcmwyuJreqgbKQtzp9vVe55xELU7CJiW8RBWwG tHI/9fyGePfwNPcC7gCcvlyd73m9qzdSTJKFNyt002BI9XWyghDqAOQgwvzufwFIN1tF5grXs/X JZFVchoW470uffnE+aMCw6adhM2tKRyQ11EanoBbM8DRnm5n+Wgkj9fQ== X-Received: by 2002:a05:6808:1b0b:b0:469:fca3:e611 with SMTP id 5614622812f47-47c892459edmr304203b6e.28.1777657422027; Fri, 01 May 2026 10:43:42 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 5614622812f47-47c763ffe6csm1675009b6e.6.2026.05.01.10.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 10:43:41 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use fully-qualified name in var_decl_name In-Reply-To: <87wlxw1o0p.fsf@redhat.com> (Andrew Burgess's message of "Fri, 24 Apr 2026 14:33:26 +0100") References: <20260423190109.1274057-1-tromey@adacore.com> <87wlxw1o0p.fsf@redhat.com> X-Attribution: Tom Date: Fri, 01 May 2026 11:43:40 -0600 Message-ID: <87ecjvgh4j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: >> This patch changes var_decl_name to use the correct full name for the >> variable. Andrew> I took a crack at writing a DWARF assembler test for this, which I've Andrew> included below. Andrew> I think it would be a good idea if a test was included with this patch. Ok, I feel a little bad that you did this. I didn't write a test for the initial patch because I felt it was already covered by gnat-llvm testing. However I get that it's better to have a pure test for this. Anyway it's always fine to push back -- I would be fine writing a test. So, thanks, and also sorry. Andrew> Feel free to use what I've written, or change it as needed. Or write Andrew> your own if this isn't suitable. Andrew> If the test below is OK, then: I verified that the test fails without the patch and passes with it, and also read the test & think it's fine. So I'm including it. Tom