Re: [PATCH] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2

[Tom Tromey <tom@tromey.com>]

>>>>> simon marchi <simon.marchi@polymtl.ca> writes:

> From: Simon Marchi <simon.marchi@polymtl.ca>
> While investigating AVR binaries for bug 34638, I stumbled on a crash of
> GDB when loading an AVR binary generated by clang:

Thanks.

> +  /* Check that the whole entry fits inside the section.  */
> +  if (addr_base_or_zero + (addr_index + 1) * (ULONGEST) addr_size
> +      > per_bfd->addr.size)

The cast to ULONGEST seems weird to me, especially since it isn't
repeated later:

> +  const gdb_byte *info_ptr
> +    = per_bfd->addr.buffer + addr_base_or_zero + addr_index * addr_size;

I'd suggest removing the cast.

Approved-By: Tom Tromey <tom@tromey.com>

Tom