From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id efpaKONxrWr3TxwAWB0awg (envelope-from ) for ; Fri, 18 Sep 2026 13:16:19 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DWHFqmsp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9D6BE1E01F; Fri, 18 Sep 2026 13:16:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C8D51E01F for ; Fri, 18 Sep 2026 13:16:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 439524BB1C33 for ; Fri, 18 Sep 2026 17:16:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 439524BB1C33 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DWHFqmsp Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id C4A234BB1C0D for ; Fri, 18 Sep 2026 17:15:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4A234BB1C0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4A234BB1C0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789751751; cv=none; b=Sl9fRIbwuMh1HCxnBflT82d7G/LCAP8zr72R/Wgd7rNgP3lEND0zaVJYb8nY81q3V++2MEaGa97+qD4TwXuQ7YwakCiFd1Bm0gTpEAy1aahfM9dtKSMt6SBAHNGD92KHiRe3ysAvxq1RwrnyCBWnTA3rKcTE04Ie4dTereiFBIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789751751; c=relaxed/simple; bh=vaa3ehenY/wTITc9HB1vEobRX+X7HdYi2ERY434p1uY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=a23FcFfnwEW7kmaUOsLZpMwoTkyIEtkUU3HiJWBbklpA4aHIjjo4K5znD6wmY49sA/yQhTlahxo1zRUJ8geEn/LTMic7X9md+33l833ZY49ddxbTwP5/MI2fJnlc3TJNXcz7WyPYS8YmV/qy/pqRVZVWkO5rJL+mHw1moBL0+/o= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DWHFqmsp reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4A234BB1C0D Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id 7a3pxKvzkv0nd7cBhxG8v1; Fri, 18 Sep 2026 17:15:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7cBgxsTP297Dy7cBgx1ObQ; Fri, 18 Sep 2026 17:15:48 +0000 X-Authority-Analysis: v=2.4 cv=asGyCTZV c=1 sm=1 tr=0 ts=6aad71c4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=uIXc6Zjd-F48pEzYK8UA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vCgOrCsw1RLAOa0saqCSW2RqBvMCCMdnj18TozKs6/w=; b=DWHFqmspeveF1XEUt4I/+6r4H0 kBuvVDvCMJQbskdSvpGttZSUqZ7mDVhBpxL2A3NztEVMZGMEXawyDBsOB+aUdThD2gvge6CSV9Khq tdZ8ViafXIvfW+B71SQDMKkhM; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:58530 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x7cBg-00000002t7j-2ZaX; Fri, 18 Sep 2026 11:15:48 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2 In-Reply-To: <20260916014513.3386344-1-simon.marchi@polymtl.ca> (simon marchi's message of "Tue, 15 Sep 2026 21:45:10 -0400") References: <20260916014513.3386344-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 18 Sep 2026 11:15:47 -0600 Message-ID: <87eceqv5to.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x7cBg-00000002t7j-2ZaX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:58530 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfK3+gW9A5kZWmlCoZ49rLaskF0d8Ejcd4quIOLRP0MrVmsRgBsqdNLjSuYkwVod5huPCRDxWiCfuyN0aXkRChyl60bJLcnkWgLJH5XYp79NJ48wr9RVr Y0E8rOBHHQ5zI0ARknn5ZoMF0NENCbwlXK273GOW4oQ/ZpxEv3UPqj49teRRYCDDD7BNeLBYRPjYDmGuVIjhRuMy6iqrNwAe4qs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> simon marchi writes: > From: Simon Marchi > While investigating AVR binaries for bug 34638, I stumbled on a crash of > GDB when loading an AVR binary generated by clang: Thanks. > + /* Check that the whole entry fits inside the section. */ > + if (addr_base_or_zero + (addr_index + 1) * (ULONGEST) addr_size > + > per_bfd->addr.size) The cast to ULONGEST seems weird to me, especially since it isn't repeated later: > + const gdb_byte *info_ptr > + = per_bfd->addr.buffer + addr_base_or_zero + addr_index * addr_size; I'd suggest removing the cast. Approved-By: Tom Tromey Tom