From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [5/5] fix test suite for MI output
Date: Tue, 15 May 2012 17:27:00 -0000 [thread overview]
Message-ID: <87d365tkwk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4FB28EE3.6090807@redhat.com> (Keith Seitz's message of "Tue, 15 May 2012 10:14:11 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Tom> It is not too hard to fix varobj to disable this new setting, if that is
Tom> preferable for some reason.
Keith> I really don't like this. UIs will now display arrays (what about
Keith> other aggregate types like struct pointers?) this way, and in the
Keith> context of varobj, it provides no additional information that the UI
Keith> isn't already providing users:
Keith> + my_array (int [10]) 0x12345678 <my_array>
Yeah, that happens for the CLI too.
Phony output:
(gdb) print my_array
$1 = <my_array> {1, 2, 3}
The place where it is an improvement is printing things that aren't
obviously globals. E.g., in gdb, printing an object that has a virtual
table, like objfile's struct sym_fns, will now nicely show the
definition.
My concern is more along the lines of whether this is going to mess up
the clients.
Tom
prev parent reply other threads:[~2012-05-15 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:01 Tom Tromey
2012-05-15 17:14 ` Keith Seitz
2012-05-15 17:27 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d365tkwk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox