From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16519 invoked by alias); 15 May 2012 17:27:37 -0000 Received: (qmail 16502 invoked by uid 22791); 15 May 2012 17:27:35 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 17:27:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4FHR8M3021991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 May 2012 13:27:08 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4FHR7iS021282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 15 May 2012 13:27:07 -0400 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [5/5] fix test suite for MI output References: <87pqa6v8fo.fsf@fleche.redhat.com> <4FB28EE3.6090807@redhat.com> Date: Tue, 15 May 2012 17:27:00 -0000 In-Reply-To: <4FB28EE3.6090807@redhat.com> (Keith Seitz's message of "Tue, 15 May 2012 10:14:11 -0700") Message-ID: <87d365tkwk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00585.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Tom> It is not too hard to fix varobj to disable this new setting, if that is Tom> preferable for some reason. Keith> I really don't like this. UIs will now display arrays (what about Keith> other aggregate types like struct pointers?) this way, and in the Keith> context of varobj, it provides no additional information that the UI Keith> isn't already providing users: Keith> + my_array (int [10]) 0x12345678 Yeah, that happens for the CLI too. Phony output: (gdb) print my_array $1 = {1, 2, 3} The place where it is an improvement is printing things that aren't obviously globals. E.g., in gdb, printing an object that has a virtual table, like objfile's struct sym_fns, will now nicely show the definition. My concern is more along the lines of whether this is going to mess up the clients. Tom