Re: [RFA] ARI fixes: Remove some sprintf calls

[Tom Tromey <tromey@redhat.com>]

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   I do not commit this as obvious because,
Pierre> I had to add some local variables to simplify 
Pierre> things for several cases.

Pierre>   Is this OK?

I like Andreas' suggestion.

Also:

Pierre> +++ windows-nat.c	8 Nov 2012 15:03:15 -0000
Pierre> @@ -613,6 +613,7 @@ struct safe_symbol_file_add_args
Pierre>  struct lm_info
Pierre>  {
Pierre>    LPVOID load_addr;
Pierre> +  unsigned long text_offset;
Pierre>  };
 
Pierre>  static struct so_list solib_start, *solib_end;
Pierre> @@ -778,6 +779,7 @@ windows_make_so (const char *name, LPVOI
Pierre>      }
Pierre>  #endif
 
Pierre> +
Pierre>    return so;
Pierre>  }

These hunks don't seem related to the patch.

Pierre> @@ -1227,11 +1229,18 @@ handle_exception (struct target_waitstat
Pierre>      default:
Pierre>        /* Treat unhandled first chance exceptions specially.  */
Pierre>        if (current_event.u.Exception.dwFirstChance)
Pierre> -	return -1;
Pierre> -      printf_unfiltered ("gdb: unknown target exception 0x%08lx at %s\n",
Pierre> -	current_event.u.Exception.ExceptionRecord.ExceptionCode,
Pierre> -	host_address_to_string (
Pierre> -	  current_event.u.Exception.ExceptionRecord.ExceptionAddress));
Pierre> +	{
Pierre> +	  DEBUG_EXCEPT (("gdb: Unknown FirstChance exception 0x%08lx at %s\n",
Pierre> +	    current_event.u.Exception.ExceptionRecord.ExceptionCode,
Pierre> +	    host_address_to_string (
Pierre> +	      current_event.u.Exception.ExceptionRecord.ExceptionAddress)));
Pierre> + 	  return -1;
Pierre> +	}
Pierre> +      else
Pierre> +	printf_unfiltered ("gdb: unknown target exception 0x%08lx at %s\n",
Pierre> +	  current_event.u.Exception.ExceptionRecord.ExceptionCode,
Pierre> +	  host_address_to_string (
Pierre> +	    current_event.u.Exception.ExceptionRecord.ExceptionAddress));

This one either.

Tom