From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17412 invoked by alias); 8 Nov 2012 21:34:58 -0000 Received: (qmail 17343 invoked by uid 22791); 8 Nov 2012 21:34:57 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 21:34:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA8LYmj8029986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Nov 2012 16:34:49 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA8LYk2S009498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Nov 2012 16:34:47 -0500 From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [RFA] ARI fixes: Remove some sprintf calls References: <4297.05661158568$1352387430@news.gmane.org> Date: Thu, 08 Nov 2012 21:34:00 -0000 In-Reply-To: <4297.05661158568$1352387430@news.gmane.org> (Pierre Muller's message of "Thu, 8 Nov 2012 16:09:59 +0100") Message-ID: <87d2znhj7t.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00214.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> I do not commit this as obvious because, Pierre> I had to add some local variables to simplify Pierre> things for several cases. Pierre> Is this OK? I like Andreas' suggestion. Also: Pierre> +++ windows-nat.c 8 Nov 2012 15:03:15 -0000 Pierre> @@ -613,6 +613,7 @@ struct safe_symbol_file_add_args Pierre> struct lm_info Pierre> { Pierre> LPVOID load_addr; Pierre> + unsigned long text_offset; Pierre> }; Pierre> static struct so_list solib_start, *solib_end; Pierre> @@ -778,6 +779,7 @@ windows_make_so (const char *name, LPVOI Pierre> } Pierre> #endif Pierre> + Pierre> return so; Pierre> } These hunks don't seem related to the patch. Pierre> @@ -1227,11 +1229,18 @@ handle_exception (struct target_waitstat Pierre> default: Pierre> /* Treat unhandled first chance exceptions specially. */ Pierre> if (current_event.u.Exception.dwFirstChance) Pierre> - return -1; Pierre> - printf_unfiltered ("gdb: unknown target exception 0x%08lx at %s\n", Pierre> - current_event.u.Exception.ExceptionRecord.ExceptionCode, Pierre> - host_address_to_string ( Pierre> - current_event.u.Exception.ExceptionRecord.ExceptionAddress)); Pierre> + { Pierre> + DEBUG_EXCEPT (("gdb: Unknown FirstChance exception 0x%08lx at %s\n", Pierre> + current_event.u.Exception.ExceptionRecord.ExceptionCode, Pierre> + host_address_to_string ( Pierre> + current_event.u.Exception.ExceptionRecord.ExceptionAddress))); Pierre> + return -1; Pierre> + } Pierre> + else Pierre> + printf_unfiltered ("gdb: unknown target exception 0x%08lx at %s\n", Pierre> + current_event.u.Exception.ExceptionRecord.ExceptionCode, Pierre> + host_address_to_string ( Pierre> + current_event.u.Exception.ExceptionRecord.ExceptionAddress)); This one either. Tom