From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Update comments to list_args_or_locals.
Date: Mon, 05 Aug 2013 13:39:00 -0000 [thread overview]
Message-ID: <87d2psb6kj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1375663603-6308-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Mon, 5 Aug 2013 08:46:43 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2013-08-05 Yao Qi <yao@codesourcery.com>
Yao> * mi/mi-cmd-stack.c: Update comments to function
Yao> list_args_or_locals.
Yao> -/* Print a list of the locals or the arguments for the currently
Yao> - selected frame. If the argument passed is 0, printonly the names
Yao> - of the variables, if an argument of 1 is passed, print the values
Yao> - as well. */
Yao> +/* Print a list of the objects for the currently selected frame FI in
Yao> + a certain form, which is determined by VALUES. The objects can be
Yao> + locals, arguments or both, which is determined by WHAT. */
I think the bit about "currently selected frame FI" is odd. Usually
"currently selected frame" refers to the one the user chose with "up" or
"down".
Otherwise it seems fine to me.
Tom
next prev parent reply other threads:[~2013-08-05 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 0:47 Yao Qi
2013-08-05 13:39 ` Tom Tromey [this message]
2013-08-05 13:43 ` Yao Qi
2013-08-05 14:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2psb6kj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox