From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25032 invoked by alias); 5 Aug 2013 13:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25023 invoked by uid 89); 5 Aug 2013 13:39:19 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 05 Aug 2013 13:39:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r75DdAsv028089 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Aug 2013 09:39:10 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r75Dd8rS020950 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 5 Aug 2013 09:39:09 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Update comments to list_args_or_locals. References: <1375663603-6308-1-git-send-email-yao@codesourcery.com> Date: Mon, 05 Aug 2013 13:39:00 -0000 In-Reply-To: <1375663603-6308-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Mon, 5 Aug 2013 08:46:43 +0800") Message-ID: <87d2psb6kj.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00136.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2013-08-05 Yao Qi Yao> * mi/mi-cmd-stack.c: Update comments to function Yao> list_args_or_locals. Yao> -/* Print a list of the locals or the arguments for the currently Yao> - selected frame. If the argument passed is 0, printonly the names Yao> - of the variables, if an argument of 1 is passed, print the values Yao> - as well. */ Yao> +/* Print a list of the objects for the currently selected frame FI in Yao> + a certain form, which is determined by VALUES. The objects can be Yao> + locals, arguments or both, which is determined by WHAT. */ I think the bit about "currently selected frame FI" is odd. Usually "currently selected frame" refers to the one the user chose with "up" or "down". Otherwise it seems fine to me. Tom