From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch +const 2/2] Unify lookup_symbol_in_objfile_symtabs
Date: Fri, 05 Dec 2014 12:37:00 -0000 [thread overview]
Message-ID: <87d27ygtmn.fsf@codesourcery.com> (raw)
In-Reply-To: <20141203170703.GC25020@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 3 Dec 2014 18:07:03 +0100")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> - sym = block_lookup_symbol (block, name, domain);
We are using 'block_lookup_symbol' here...
> - if (sym)
> - {
> - block_found = block;
> - return fixup_symbol_section (sym, objfile);
> - }
> - }
> +
> + sym = lookup_symbol_in_objfile_symtabs (objfile, GLOBAL_BLOCK, name,
> + domain);
... but lookup_symbol_in_objfile_symtabs calls
'block_lookup_symbol_primary'. Is it because we are iterating COMPUNITS
(primary symtab?) so block_lookup_symbol is equivalent to
block_lookup_symbol_primary under this context?
--
Yao (齐尧)
next prev parent reply other threads:[~2014-12-05 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 17:07 Jan Kratochvil
2014-12-05 12:37 ` Yao Qi [this message]
2014-12-05 15:15 ` Jan Kratochvil
2014-12-05 18:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d27ygtmn.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox