From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10503 invoked by alias); 5 Dec 2014 12:37:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10480 invoked by uid 89); 5 Dec 2014 12:37:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SUBJ_OBFU_PUNCT_MANY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Dec 2014 12:37:39 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1Xws8e-000402-Ns from Yao_Qi@mentor.com ; Fri, 05 Dec 2014 04:37:36 -0800 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Fri, 5 Dec 2014 04:37:35 -0800 From: Yao Qi To: Jan Kratochvil CC: Subject: Re: [patch +const 2/2] Unify lookup_symbol_in_objfile_symtabs References: <20141203170703.GC25020@host2.jankratochvil.net> Date: Fri, 05 Dec 2014 12:37:00 -0000 In-Reply-To: <20141203170703.GC25020@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 3 Dec 2014 18:07:03 +0100") Message-ID: <87d27ygtmn.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00131.txt.bz2 Jan Kratochvil writes: > - sym =3D block_lookup_symbol (block, name, domain); We are using 'block_lookup_symbol' here... > - if (sym) > - { > - block_found =3D block; > - return fixup_symbol_section (sym, objfile); > - } > - } > +=20=20=20=20=20=20 > + sym =3D lookup_symbol_in_objfile_symtabs (objfile, GLOBAL_BLOCK, n= ame, > + domain); ... but lookup_symbol_in_objfile_symtabs calls 'block_lookup_symbol_primary'. Is it because we are iterating COMPUNITS (primary symtab?) so block_lookup_symbol is equivalent to block_lookup_symbol_primary under this context? --=20 Yao (=E9=BD=90=E5=B0=A7)