From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH v2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902)
Date: Wed, 18 Mar 2015 19:39:00 -0000 [thread overview]
Message-ID: <87d2463xit.fsf@redhat.com> (raw)
In-Reply-To: <5509CD9F.8060803@redhat.com> (Pedro Alves's message of "Wed, 18 Mar 2015 19:10:23 +0000")
On Wednesday, March 18 2015, Pedro Alves wrote:
> On 03/16/2015 11:53 PM, Sergio Durigan Junior wrote:
>
>> To summarize: I decided to change this part of the code, and make GDB
>> actually ignore (i.e., return 0) mappings marked as UNMODIFIED. After
>> all, as explained above, this is what Linux does.
>
> I can't tell whether we'll still need the UNKNOWN state after that,
> but offhand, if a mapping isn't supposed to be dumped, why not
> just skip calling the callback (gcore_create_callback)?
That is another option. Initially we would call gcore_create_callback
because at least the segment header should be created in the corefile;
however, as I mentioned before, Linux doesn't do that (therefore GDB
shouldn't too).
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2015-03-18 19:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 3:48 [PATCH] " Sergio Durigan Junior
2015-03-05 15:48 ` Jan Kratochvil
2015-03-05 20:53 ` Sergio Durigan Junior
2015-03-05 20:57 ` Jan Kratochvil
2015-03-11 20:02 ` Oleg Nesterov
2015-03-12 11:31 ` Sergio Durigan Junior
2015-03-12 14:36 ` vvar, gup && coredump Oleg Nesterov
2015-03-12 16:29 ` Andy Lutomirski
2015-03-12 16:56 ` Oleg Nesterov
2015-03-12 17:18 ` Andy Lutomirski
2015-03-12 17:40 ` Oleg Nesterov
2015-03-12 17:45 ` Sergio Durigan Junior
2015-03-12 18:04 ` Oleg Nesterov
2015-03-13 4:50 ` Sergio Durigan Junior
2015-03-13 15:06 ` Oleg Nesterov
2015-03-12 17:56 ` Andy Lutomirski
2015-03-12 18:28 ` Oleg Nesterov
2015-03-12 17:48 ` Oleg Nesterov
2015-03-12 17:55 ` Andy Lutomirski
2015-03-12 18:16 ` Oleg Nesterov
2015-03-12 18:23 ` Sergio Durigan Junior
2015-03-12 18:20 ` Pedro Alves
2015-03-12 18:26 ` Andy Lutomirski
2015-03-16 19:03 ` install_special_mapping && vm_pgoff (Was: vvar, gup && coredump) Oleg Nesterov
2015-03-16 19:20 ` Andy Lutomirski
2015-03-16 19:46 ` Oleg Nesterov
2015-03-17 13:45 ` Oleg Nesterov
2015-03-18 1:45 ` Andy Lutomirski
2015-03-18 18:08 ` Oleg Nesterov
2015-03-16 19:40 ` Pedro Alves
2015-03-12 15:02 ` [PATCH] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902) Oleg Nesterov
2015-03-12 15:46 ` Pedro Alves
2015-03-12 15:57 ` Jan Kratochvil
2015-03-12 16:19 ` Pedro Alves
2015-03-12 16:07 ` Oleg Nesterov
2015-03-12 16:28 ` Pedro Alves
2015-03-12 17:37 ` Sergio Durigan Junior
2015-03-12 21:39 ` [PATCH v2] " Sergio Durigan Junior
2015-03-13 19:34 ` Pedro Alves
2015-03-16 23:53 ` Sergio Durigan Junior
2015-03-18 19:10 ` Pedro Alves
2015-03-18 19:39 ` Sergio Durigan Junior [this message]
2015-03-14 9:40 ` Eli Zaretskii
2015-03-16 2:42 ` Sergio Durigan Junior
2015-03-13 19:37 ` [PATCH] " Pedro Alves
2015-03-13 19:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2463xit.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=oleg@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox