From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105448 invoked by alias); 18 Mar 2015 19:39:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105368 invoked by uid 89); 18 Mar 2015 19:39:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Mar 2015 19:39:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8BA83CC082 for ; Wed, 18 Mar 2015 19:39:56 +0000 (UTC) Received: from localhost (ovpn-113-183.phx2.redhat.com [10.3.113.183]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2IJds3K026087 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 18 Mar 2015 15:39:56 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Jan Kratochvil , Oleg Nesterov Subject: Re: [PATCH v2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902) References: <878ufc9kau.fsf@redhat.com> <87r3stnbdw.fsf@redhat.com> <55033BD3.8060800@redhat.com> <871tko8pom.fsf@redhat.com> <5509CD9F.8060803@redhat.com> X-URL: http://blog.sergiodj.net Date: Wed, 18 Mar 2015 19:39:00 -0000 In-Reply-To: <5509CD9F.8060803@redhat.com> (Pedro Alves's message of "Wed, 18 Mar 2015 19:10:23 +0000") Message-ID: <87d2463xit.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00560.txt.bz2 On Wednesday, March 18 2015, Pedro Alves wrote: > On 03/16/2015 11:53 PM, Sergio Durigan Junior wrote: > >> To summarize: I decided to change this part of the code, and make GDB >> actually ignore (i.e., return 0) mappings marked as UNMODIFIED. After >> all, as explained above, this is what Linux does. > > I can't tell whether we'll still need the UNKNOWN state after that, > but offhand, if a mapping isn't supposed to be dumped, why not > just skip calling the callback (gcore_create_callback)? That is another option. Initially we would call gcore_create_callback because at least the segment header should be created in the corefile; however, as I mentioned before, Linux doesn't do that (therefore GDB shouldn't too). -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/