From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Delete test target descriptions when exiting
Date: Mon, 30 Jul 2018 21:26:00 -0000 [thread overview]
Message-ID: <87d0v4o1oa.fsf@tromey.com> (raw)
In-Reply-To: <1532983661-8486-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 30 Jul 2018 16:47:41 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> Looking at the address sanitizer output, this was a quite low hanging
Simon> fruit. We create target_desc objects for testing that we never free.
Simon> Saving them in unique_ptrs takes care of it.
FWIW this looks fine to me.
As I mentioned a few minutes ago, I have a bunch of -fsanitize=address
and -fsanitize=undefined patches. I sent a few a little while ago, but
I have more here. I thought I'd mention the state of this so we can
avoid duplicating work.
I have *not* looked at the AddressSanitizer leak reports at all, and I
wasn't planning to.
And, I don't yet have patches for any of the existing bugs:
https://sourceware.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=43341&longdesc=AddressSanitizer&longdesc_type=allwordssubstr&product=gdb&query_format=advanced
Of these, only 22860 occurs during an ordinary "make check"; for that
one I have an idea of how to fix it, but I haven't tried it.
Tom
next prev parent reply other threads:[~2018-07-30 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 20:48 Simon Marchi
2018-07-30 21:26 ` Tom Tromey [this message]
2018-07-30 23:07 ` [PP?] " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0v4o1oa.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox