From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90753 invoked by alias); 30 Jul 2018 21:26:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90736 invoked by uid 89); 30 Jul 2018 21:26:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=22860, sk:Address X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 21:26:46 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 5915BF473 for ; Mon, 30 Jul 2018 16:26:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kFgUfW2KCbXuJkFgcfbgDA; Mon, 30 Jul 2018 16:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kAqQ1/DvrH8drfBrJBDX41hPN7VUJEN8qXMleG9wolY=; b=iJQojnzBr5drM3vKJaLD/8SxQf 1eTPDUYCUMamDaP9Dw2xuHvZ/RSxkJTrMbLLLNH6SAUCnmowmwqbDqMM5DOsyw97WMs1Qlg+yExUn i+jkXLU5D3m5JKSAaIhmzekiQ; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:33856 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fkFgT-004L6q-T9; Mon, 30 Jul 2018 16:26:30 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH] Delete test target descriptions when exiting References: <1532983661-8486-1-git-send-email-simon.marchi@ericsson.com> Date: Mon, 30 Jul 2018 21:26:00 -0000 In-Reply-To: <1532983661-8486-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 30 Jul 2018 16:47:41 -0400") Message-ID: <87d0v4o1oa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00798.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Looking at the address sanitizer output, this was a quite low hanging Simon> fruit. We create target_desc objects for testing that we never free. Simon> Saving them in unique_ptrs takes care of it. FWIW this looks fine to me. As I mentioned a few minutes ago, I have a bunch of -fsanitize=address and -fsanitize=undefined patches. I sent a few a little while ago, but I have more here. I thought I'd mention the state of this so we can avoid duplicating work. I have *not* looked at the AddressSanitizer leak reports at all, and I wasn't planning to. And, I don't yet have patches for any of the existing bugs: https://sourceware.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=43341&longdesc=AddressSanitizer&longdesc_type=allwordssubstr&product=gdb&query_format=advanced Of these, only 22860 occurs during an ordinary "make check"; for that one I have an idea of how to fix it, but I haven't tried it. Tom