Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Stephan Rohr <stephan.rohr@intel.com>,
	 gdb-patches@sourceware.org, eliz@gnu.org,  guinevere@redhat.com,
	 tom@tromey.com
Subject: Re: [PATCH v4 1/1] gdb: remove check for minimal symbols in 'start_command'
Date: Tue, 28 Jan 2025 10:47:06 -0700	[thread overview]
Message-ID: <87cyg6omp1.fsf@tromey.com> (raw)
In-Reply-To: <20250127162830.5d10b4f7@f41-zbm-amd> (Kevin Buettner's message of "Mon, 27 Jan 2025 16:28:30 -0700")

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

Kevin> The one thing that concerns me is the comment regarding the Ada language
Kevin> and the need to search for minimal symbols.  I'm going to give this patch
Kevin> an "Approved-by", but please wait a few days for others to weigh in
Kevin> regarding this concern.

In Ada programs, the name of the 'main' program is stored in an array.
gdb reads this from the inferior (normally from the section data by
setting trust_readonly=true) by looking up the minimal symbol.

See ada-lang.c:ada_main_name.

I'd guess this patch would just cause gdb to behave differently here:
rather than getting an error, you'd get a stop in the "C main", which is
some generated Ada procedure that the user won't recognize.

Anyway it hardly seems fatal.  Perhaps we need some better way to
communicate the Ada main for this target, not sure.

Tom

  reply	other threads:[~2025-01-28 17:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 15:42 [PATCH v4 0/1] gdb: remove minimal symbol check " Stephan Rohr
2025-01-27 15:42 ` [PATCH v4 1/1] gdb: remove check for minimal symbols " Stephan Rohr
2025-01-27 23:28   ` Kevin Buettner
2025-01-28 17:47     ` Tom Tromey [this message]
2025-02-10 17:09     ` Guinevere Larsen
2025-02-11 14:51       ` Tom Tromey
2025-02-11 15:53         ` Rohr, Stephan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyg6omp1.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=kevinb@redhat.com \
    --cc=stephan.rohr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox