From: Stephan Rohr <stephan.rohr@intel.com>
To: gdb-patches@sourceware.org
Cc: eliz@gnu.org, guinevere@redhat.com, tom@tromey.com
Subject: [PATCH v4 0/1] gdb: remove minimal symbol check in 'start_command'
Date: Mon, 27 Jan 2025 07:42:10 -0800 [thread overview]
Message-ID: <20250127154211.2509613-1-stephan.rohr@intel.com> (raw)
Hello,
this is version 4 of my patch fixing the 'start' command for a specific
scenario on Windows.
Based on the discussion from version 3 [1], I decided to remove the
minimal symbols check completely. The motiviation for this is:
* Adding a try / catch block in 'tbreak' or in 'run_command_1' is not straight
forward. If 'main' cannot be resolved, a 'NOT_FOUND_ERROR' is thrown.
* A 'No symbol table is loaded. Use the "file" command' error is printed.
* The error is consumed in 'create_breakpoint' and the user may insert a
pending breakpoint. The error only rethrown if pending breakpoints are not
supported.
I appreciate your feedback.
Stephan
[1]: https://sourceware.org/pipermail/gdb-patches/2025-January/214603.html
https://sourceware.org/pipermail/gdb-patches/2025-January/214732.html
Rohr, Stephan (1):
gdb: remove check for minimal symbols in 'start_command'
gdb/infcmd.c | 6 ------
1 file changed, 6 deletions(-)
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2025-01-27 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 15:42 Stephan Rohr [this message]
2025-01-27 15:42 ` [PATCH v4 1/1] gdb: remove check for minimal symbols " Stephan Rohr
2025-01-27 23:28 ` Kevin Buettner
2025-01-28 17:47 ` Tom Tromey
2025-02-10 17:09 ` Guinevere Larsen
2025-02-11 14:51 ` Tom Tromey
2025-02-11 15:53 ` Rohr, Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127154211.2509613-1-stephan.rohr@intel.com \
--to=stephan.rohr@intel.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox