Re: [RFC PATCH 1/5] gdb/aarch64: Enable FPMR for AArch64 in gdb on Linux

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Luis <luis.machado.foss@gmail.com> writes:

> On 05/09/2025 14:17, Ezra.Sitorus@arm.com wrote:
>> index 679d845df74..731d4680248 100644
>> --- a/gdb/arch/aarch64.h
>> +++ b/gdb/arch/aarch64.h
>> @@ -34,6 +34,7 @@ struct aarch64_features
>>     uint64_t vq = 0;
>>     bool pauth = false;
>>     bool mte = false;
>> +  bool fpmr = false;
>>       /* A positive TLS value indicates the number of TLS registers available.  */
>>     uint8_t tls = 0;
>> @@ -68,7 +69,8 @@ inline bool operator==(const aarch64_features &lhs, const
> aarch64_features &rhs)
>>       && lhs.svq == rhs.svq
>>       && lhs.sme2 == rhs.sme2
>>       && lhs.gcs == rhs.gcs
>> -    && lhs.gcs_linux == rhs.gcs_linux;
>> +    && lhs.gcs_linux == rhs.gcs_linux
>> +    && lhs.fpmr == rhs.fpmr;
>>   }
>
> Do you also need to update the operator() to account for fpmr? It computes the hash of the
> feature based on what features are present.
>
> Unrelated, but looking at the code, it may be the case we missed adding gcs and gcs_linux
> to this operator.

You're right, I missed that one. I'll submit a patch fixing this.

-- 
Thiago