From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UV+zLzwQwmhubz8AWB0awg (envelope-from ) for ; Wed, 10 Sep 2025 19:56:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=vbdZ++As; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B3BA51E047; Wed, 10 Sep 2025 19:56:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2D9821E047 for ; Wed, 10 Sep 2025 19:56:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD5CC3858C39 for ; Wed, 10 Sep 2025 23:56:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD5CC3858C39 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=vbdZ++As Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id D45FB3858D35 for ; Wed, 10 Sep 2025 23:56:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D45FB3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D45FB3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757548570; cv=none; b=HVs9RYyBXI8g6ygyY/H075732VmCcNq93L0LoRBuimyEBTpJIoApS1AJgtSn2JVoYOPrqrm9ReAjA1GaRgx8QjfCSDm69czBk0U9f+nALWxQ/R0RiXWbLMQumWvR/91RWBy9ntKNVL8KmBPNjidG5M3baZn/6ORAt3q4SGwj1HY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757548570; c=relaxed/simple; bh=WKDgYyYWYk97Mq+lD2Mji2osS0yMud1D5NU2KuupHZI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YTvddzDPm1uWZzXSTGG/zB5oIKx8SxMaBLftmEszENaaD/q6CQQAm4zN4usOkQxLPePnf3Hk3z/qBY18AAJ0A8svEOlas8Ex9hrBrDhOOr1y7TkFtCFk45h6g8DekHxTswhvB0xdFtRcZo1IdSkRwK+g5ipl4Zqd7Xprvv+a+mA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D45FB3858D35 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-2570bf6050bso715735ad.2 for ; Wed, 10 Sep 2025 16:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757548569; x=1758153369; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=C/jiRJteqbWvlimxmFuWXQE4jQc/+UpfKqwuADnwFug=; b=vbdZ++AsyuevJ5V+IOcL0HMRHi5L+qXWVUzzlYCT6UKNinQMnCGHaLBiw3dFfN7TWS H5XoANcDdeyP797TkO9jIeDKZJgD7zLFU2lfM01nZc0rvvQm/kqInGI/ZAcn2awjPAgn Xm2kjCadquqsREbGMEYtnby9gFLyPfFyGdDcxCFXWVPeg1iyJphrCxN0mt52SfOd7is5 X/rh6guXfllQR7A2Iz2KswlShKFhbEBt5lOsfozrG9e4LgL9sujB4mlHwpllQ3EFOLT/ 3BQN0v62JwX/izVTgRcK8yTCES4iYi6AMjgUjRHlL4AgWrxJCvKVVLNfeqWi7FrEukPt a9YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757548569; x=1758153369; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C/jiRJteqbWvlimxmFuWXQE4jQc/+UpfKqwuADnwFug=; b=DdB8p+jM2vkMa7zeLMXf0mV7DtLJd/InkSbKuqLlStbKmL1F1Cwo40E1nzAG2+E3+C 3l7dWlFDI1+FQhD/1B9Y8bt/ZtQ16jNSEs3Gsdgs4/0PNYnYUCyG6G+Ljqsia6L+xmdp 6e18/2sblL3oXY+M0ZW68QsN9v3OKLDw5mG1fCX2JM6NH/2JdlUJKHgMO/UJ3OJcRPTO tNazjK7zMlBRBLIIVpywWgL4Yj+geOXVU7aFigVZEoyTCK7iIwRiYzPSEq45THPg04x4 LuV2TDfT+vTUG1up/cey3YTuyk8Sif9s6ARRtYO3mTMUqiOnixXiQOS2KlbuUuaBjkN4 RULw== X-Forwarded-Encrypted: i=1; AJvYcCVs3A3uKFKhrpZh6BzOFrsRQmkinjwbSZqlRB0JBFXct9aJ63zc/4kn4UV+X9VbMpFU+zQ5wYD4eq6uiw==@sourceware.org X-Gm-Message-State: AOJu0YxR4MhoW6lFlopOBK2Lw51Z3va0njn+gQcwrbTxlfgu4oVl84f5 0xcpPsBpgdeSj/ncOHBzgOeKsVsZHbZhS0nut6TzjxwvMpk6qpOzVHSPjXWv1S31Kck= X-Gm-Gg: ASbGncsHEyGlQ4yJepSI0hTomXzQP6Sk2ukV5+aIjRVowb4g+ctLotnjwYJwF/di1tJ 8seb3IvdvuwbLzQ6RfEW3tcDGBz6b21gaFl6oBsog7OJSC3LzucrC6LcQdR7Odu5JZmf4TIJwQ+ LyM5d5SGn2fZx+kQwiT3E0jgpx+dXJZ95uFigQoXAOrpAVzHRvl395blLQ30l7D8ypHDSbESNb4 tjaQJJRtNdA/GuyXfapC9V2TGvqGJulAGDY6VWKoR1V7FUYmL8WYT82IkHuitxZhCa5OzwOBLXw zLxdM8/c6DU220V0B7FpwjX0BAnW+7U3A+ge6fwCAcOC6fJNatpO/Exa68/ZKESB4w+fbpPDfKQ KfuH56shKBUX53X6oLLcMbiGlK64Cwe6h X-Google-Smtp-Source: AGHT+IFLJryAkn5aqNG7aMPjlvlD1Mv4ggfcVrTrgtVvXsw2zxq4JqCBodyxNfjBzB3ThFAuFtMGNA== X-Received: by 2002:a17:903:b8b:b0:249:17d1:f1d5 with SMTP id d9443c01a7336-25176729912mr193766015ad.60.1757548568869; Wed, 10 Sep 2025 16:56:08 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:e23e:713e:98d0:a6b4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25a27422bb7sm38804355ad.30.2025.09.10.16.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 16:56:08 -0700 (PDT) From: Thiago Jung Bauermann To: Luis Cc: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Subject: Re: [RFC PATCH 1/5] gdb/aarch64: Enable FPMR for AArch64 in gdb on Linux In-Reply-To: <606b962c-d505-4e68-9090-20c003a9c6ed@gmail.com> (Luis's message of "Sun, 7 Sep 2025 23:55:29 +0100") References: <20250905131707.77027-1-Ezra.Sitorus@arm.com> <20250905131707.77027-2-Ezra.Sitorus@arm.com> <606b962c-d505-4e68-9090-20c003a9c6ed@gmail.com> User-Agent: mu4e 1.12.11; emacs 30.1 Date: Wed, 10 Sep 2025 20:56:05 -0300 Message-ID: <87cy7x50bu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Luis writes: > On 05/09/2025 14:17, Ezra.Sitorus@arm.com wrote: >> index 679d845df74..731d4680248 100644 >> --- a/gdb/arch/aarch64.h >> +++ b/gdb/arch/aarch64.h >> @@ -34,6 +34,7 @@ struct aarch64_features >> uint64_t vq = 0; >> bool pauth = false; >> bool mte = false; >> + bool fpmr = false; >> /* A positive TLS value indicates the number of TLS registers available. */ >> uint8_t tls = 0; >> @@ -68,7 +69,8 @@ inline bool operator==(const aarch64_features &lhs, const > aarch64_features &rhs) >> && lhs.svq == rhs.svq >> && lhs.sme2 == rhs.sme2 >> && lhs.gcs == rhs.gcs >> - && lhs.gcs_linux == rhs.gcs_linux; >> + && lhs.gcs_linux == rhs.gcs_linux >> + && lhs.fpmr == rhs.fpmr; >> } > > Do you also need to update the operator() to account for fpmr? It computes the hash of the > feature based on what features are present. > > Unrelated, but looking at the code, it may be the case we missed adding gcs and gcs_linux > to this operator. You're right, I missed that one. I'll submit a patch fixing this. -- Thiago