From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 5/5] [gdb/python] Use py_{none,notimplemented} more often
Date: Fri, 15 May 2026 11:38:34 -0600 [thread overview]
Message-ID: <87cxywh8th.fsf@tromey.com> (raw)
In-Reply-To: <20260515135834.2502165-5-tdevries@suse.de> (Tom de Vries's message of "Fri, 15 May 2026 15:58:34 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> if (!PyObject_TypeCheck (other, &block_object_type)
Tom> || (op != Py_EQ && op != Py_NE))
Tom> - {
Tom> - Py_INCREF (Py_NotImplemented);
Tom> - return Py_NotImplemented;
Tom> - }
Tom> + return py_notimplemented ().release ();
Aha, I see now why you added py_notimplemented.
Sorry about that, I was reading the patches in order.
This is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-05-15 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:58 [PATCH v3 1/5] [gdb/python] Introduce py_{none, true, false, notimplemented} functions Tom de Vries
2026-05-15 13:58 ` [PATCH v3 2/5] [gdb/python] Remove Py_RETURN_{NONE, TRUE, FALSE, NOTIMPLEMENTED} Tom de Vries
2026-05-15 13:58 ` [PATCH v3 3/5] [gdb/python] Undefine " Tom de Vries
2026-05-15 14:05 ` Tom de Vries
2026-05-15 17:40 ` Tom Tromey
2026-05-15 13:58 ` [PATCH v3 4/5] [gdb/python] Use py_{none,false} more often Tom de Vries
2026-05-15 17:39 ` Tom Tromey
2026-05-15 13:58 ` [PATCH v3 5/5] [gdb/python] Use py_{none,notimplemented} " Tom de Vries
2026-05-15 17:38 ` Tom Tromey [this message]
2026-05-15 17:36 ` [PATCH v3 1/5] [gdb/python] Introduce py_{none, true, false, notimplemented} functions Tom Tromey
2026-05-15 17:44 ` Tom de Vries
2026-05-15 18:36 ` Tom Tromey
2026-05-15 19:08 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxywh8th.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox