From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ikydJD5aB2opwD0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 13:39:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Sr7uxN8w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7FEB61E067; Fri, 15 May 2026 13:39:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A331F1E067 for ; Fri, 15 May 2026 13:39:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A34640A1FBB for ; Fri, 15 May 2026 17:39:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A34640A1FBB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Sr7uxN8w Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id EDD974BA2E04 for ; Fri, 15 May 2026 17:38:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDD974BA2E04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDD974BA2E04 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778866718; cv=none; b=Acfh8smsteQ/W26NLHk7jdAot5r7RkiJe1CKt2Etc+VUZIu5fIl7zHN1Ss7wvMCIjzw2gRHm0yeltVXJRy+WRVJ4f1CEnoucBmt8PS2isSQWNhrJIxgAvA4jXvs8l6W83B0KOOxOrGRTvJ3t9JUs7xv2YjGNDuWtYcmpduh97SM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778866718; c=relaxed/simple; bh=Rzp2olgcjs8xc31lSTXHQphqYRZLlvO0tzH/3/7q/0o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kqzw2Jki5IcAUwI4xnlvgDbU6qWBg6pp2fZ4dVOEcYh98jxU1BbaLM8VJd1+lqVxYP2E6FVsx1NqNsbflQrIWktVoSrIjGFtvNCL4GrUJwzQtAkRnhV5HcC1VZsmf5R6LH8fs5YFV4yI8iBDVMuKq2XVfghOolu2GDI6sXf4w/Q= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Sr7uxN8w reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDD974BA2E04 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id Ne67w0HGZrDqVNwUewYwPi; Fri, 15 May 2026 17:38:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NwUdwJTOZZYlBNwUdwUIrD; Fri, 15 May 2026 17:38:35 +0000 X-Authority-Analysis: v=2.4 cv=MJRgmNZl c=1 sm=1 tr=0 ts=6a075a1c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=OP65JsSyho_iDqnpgk4A:9 a=QYH75iMubAgA:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nPtFSik7RD+j7NRcjfkZsqt0rc/m2cGxkLPTxUmt68Q=; b=Sr7uxN8wrr9ohLmSAbkqcP57nL aTp5BVaJN4Lc/khnktaalzpk0hTnU9rfyKtwpjEEYxkV5+FWGSVbSE3hiv2Mh0Yh/2TZDDa8VKMFs nQxCyZXmWPJSZkklJZf9jDtTz; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:49674 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wNwUd-00000001iOB-0B9e; Fri, 15 May 2026 11:38:35 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 5/5] [gdb/python] Use py_{none,notimplemented} more often In-Reply-To: <20260515135834.2502165-5-tdevries@suse.de> (Tom de Vries's message of "Fri, 15 May 2026 15:58:34 +0200") References: <20260515135834.2502165-1-tdevries@suse.de> <20260515135834.2502165-5-tdevries@suse.de> X-Attribution: Tom Date: Fri, 15 May 2026 11:38:34 -0600 Message-ID: <87cxywh8th.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wNwUd-00000001iOB-0B9e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:49674 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJdbn+iX+YuJ76W3Tvq8oL/In40TOQUxpYC2ydHtIJi68iZBNKOANtgECaKsZewu8yY0m/lTYaAKU39uwkmyoBNFdzeq3Pjt+HWeDUQoA2VTPFGBqf3T 1DqcdrrcPZwCj9DajDu42aJs6jEw6EWnMGDcA77seCuE0S2lZpJEf1NrQgEwQW5qIJT5K+O3CEgU3ZDPjLqn7W+yEgxHQrKm0r4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> if (!PyObject_TypeCheck (other, &block_object_type) Tom> || (op != Py_EQ && op != Py_NE)) Tom> - { Tom> - Py_INCREF (Py_NotImplemented); Tom> - return Py_NotImplemented; Tom> - } Tom> + return py_notimplemented ().release (); Aha, I see now why you added py_notimplemented. Sorry about that, I was reading the patches in order. This is ok. Approved-By: Tom Tromey Tom