Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Yury Khrustalev <yury.khrustalev@arm.com>,
	Muhammad Kamran <muhammad.kamran@arm.com>
Cc: Kevin Buettner <kevinb@redhat.com>,
	gdb-patches@sourceware.org,
	Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
	Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
	Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	Carlos O'Donell <carlos@redhat.com>,
	Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH v5 0/2] gdb: Fix internal inferior calls through GNU IFUNCs
Date: Thu, 20 Aug 2026 12:55:08 +0100	[thread overview]
Message-ID: <87cxvd0zxf.fsf@redhat.com> (raw)
In-Reply-To: <aobCj1DvGsHA3kGv@arm.com>

Yury Khrustalev <yury.khrustalev@arm.com> writes:

> On Mon, Aug 17, 2026 at 10:19:18AM +0100, Muhammad Kamran wrote:
>> 
>> On 16/08/2026 08:24, Kevin Buettner wrote:
>> > On Tue, 11 Aug 2026 13:12:17 +0000
>> > Muhammad Kamran <muhammad.kamran@arm.com> wrote:
>> > 
>> > ...
>> >
>> > Andrew gave conditional approval for both parts in his v4 replies.
>> > I've looked over this v5 series; IMO, you've completely addressed his
>> > concerns.  Therefore, I think you can consider this version approved;
>> > but do add Andrew's Approved-By tag.  If you need a maintainer to push
>> > it for you, I'll be happy to do that.
>> 
>> Hi Kevin,
>> 
>> Thanks for reviewing.
>> 
>> I don't have write access, so I'd appreciate it if you could please push
>> the series for me.
>> 
>> Andrew gave his Approved-By on both patches, so please feel free to add:
>> 
>> Approved-By: Andrew Burgess <aburgess@redhat.com>
>> 
>> Thanks,
>> Kamran
>> 
>
> Pushed to master.

Thanks for taking care of this.  I had meant to do this yesterday, but
got side tracked.

I've also back-ported these patches to gdb-18-branch.  I know that this
issue is causing problems on AArch64 with the latest versions (or
upcoming versions) of glibc, so having this fix in the next release will
be a good win for a lot of users.

Thanks,
Andrew


      reply	other threads:[~2026-08-20 11:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 13:12 Muhammad Kamran
2026-08-11 13:12 ` [PATCH v5 1/2] gdb: Preserve IFUNC marker when finding inferior functions Muhammad Kamran
2026-08-11 13:12 ` [PATCH v5 2/2] gdb: Keep original IFUNC return type when target type is unknown Muhammad Kamran
2026-08-16  7:24 ` [PATCH v5 0/2] gdb: Fix internal inferior calls through GNU IFUNCs Kevin Buettner
2026-08-17  9:19   ` Muhammad Kamran
2026-08-20  9:02     ` Yury Khrustalev
2026-08-20 11:55       ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxvd0zxf.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=muhammad.kamran@arm.com \
    --cc=simark@simark.ca \
    --cc=thiago.bauermann@linaro.org \
    --cc=yury.khrustalev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox