Re: [RFA 5/4 take 2] Improved linker-debugger interface

[Tom Tromey <tromey@redhat.com>]

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> So, with this patch GDB is not three but ten times faster.

Excellent work.

Gary> +/* See comments in objfiles.h.  */
Gary> +
Gary> +void
Gary> +inhibit_section_map_updates (void)
Gary> +{
Gary> +  get_objfile_pspace_data (current_program_space)->inhibit_updates = 1;
Gary> +
Gary> +}

Spurious blank line before the "}".

Gary> @@ -1820,6 +1820,18 @@ svr4_handle_solib_event (bpstat bs)
[...]
Gary> +  inhibit_section_map_updates ();
[...]
Gary> +  resume_section_map_updates ();

If there is any possibility of throwing an exception between these
calls, then there should be a cleanup instead.

I didn't dig up the patch supplying svr4_handle_solib_event to see for
myself.

If there is no possibility, then this patch is ok.

Tom