From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93112-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26308 invoked by alias); 25 Jul 2012 18:22:29 -0000
Received: (qmail 26272 invoked by uid 22791); 25 Jul 2012 18:22:27 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 18:22:14 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PIMEXx007472	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 25 Jul 2012 14:22:14 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PIMCj0020452	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 25 Jul 2012 14:22:13 -0400
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA 5/4 take 2] Improved linker-debugger interface
References: <20120719151913.GF25093@redhat.com>
Date: Wed, 25 Jul 2012 18:22:00 -0000
In-Reply-To: <20120719151913.GF25093@redhat.com> (Gary Benson's message of	"Thu, 19 Jul 2012 16:19:13 +0100")
Message-ID: <87boj3hfaj.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00568.txt.bz2

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> So, with this patch GDB is not three but ten times faster.

Excellent work.

Gary> +/* See comments in objfiles.h.  */
Gary> +
Gary> +void
Gary> +inhibit_section_map_updates (void)
Gary> +{
Gary> +  get_objfile_pspace_data (current_program_space)->inhibit_updates = 1;
Gary> +
Gary> +}

Spurious blank line before the "}".

Gary> @@ -1820,6 +1820,18 @@ svr4_handle_solib_event (bpstat bs)
[...]
Gary> +  inhibit_section_map_updates ();
[...]
Gary> +  resume_section_map_updates ();

If there is any possibility of throwing an exception between these
calls, then there should be a cleanup instead.

I didn't dig up the patch supplying svr4_handle_solib_event to see for
myself.

If there is no possibility, then this patch is ok.

Tom