Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug 15293 Ignore-count does not work properly with dprintf
Date: Fri, 19 Apr 2013 18:40:00 -0000	[thread overview]
Message-ID: <87bo9awjgf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon3vZ_AyasT=aLvbxS3zBA-AES5Ed3sXkAEvC-Xw+6Yj2w@mail.gmail.com>	(Hui Zhu's message of "Fri, 19 Apr 2013 17:43:03 +0800")

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> This patch fix http://sourceware.org/bugzilla/show_bug.cgi?id=15293
Hui> Also I update dprintf.exp for this bug.
Hui> Please help me review it.

After this patch, "ignore" doesn't cause the program to stop -- this
part seems correct.

But it seems to me that "ignore" should make the "dprintf" not print
anything at all.  Otherwise, what is being ignored?

Hui> +gdb_test "ignore \$bpnum 1" ".*Will ignore next crossing of breakpoint.*"

I was surprised to find that this didn't interfere with the  "info break"
test later on.

Tom


  reply	other threads:[~2013-04-19 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 14:31 Hui Zhu
2013-04-19 18:40 ` Tom Tromey [this message]
2013-04-22  6:19   ` Hui Zhu
2013-04-22 23:53     ` Tom Tromey
2013-04-23 17:13       ` Hui Zhu
2013-04-25 12:24         ` Tom Tromey
2013-04-25 13:49           ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo9awjgf.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox