From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100692-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3637 invoked by alias); 19 Apr 2013 16:53:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3628 invoked by uid 89); 19 Apr 2013 16:53:25 -0000
X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 16:53:25 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGrNYh024762	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 19 Apr 2013 12:53:23 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGrLSw001089	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 19 Apr 2013 12:53:21 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug 15293 Ignore-count does not work properly with dprintf
References: <CANFwon3vZ_AyasT=aLvbxS3zBA-AES5Ed3sXkAEvC-Xw+6Yj2w@mail.gmail.com>
Date: Fri, 19 Apr 2013 18:40:00 -0000
In-Reply-To: <CANFwon3vZ_AyasT=aLvbxS3zBA-AES5Ed3sXkAEvC-Xw+6Yj2w@mail.gmail.com>	(Hui Zhu's message of "Fri, 19 Apr 2013 17:43:03 +0800")
Message-ID: <87bo9awjgf.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00618.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> This patch fix http://sourceware.org/bugzilla/show_bug.cgi?id=15293
Hui> Also I update dprintf.exp for this bug.
Hui> Please help me review it.

After this patch, "ignore" doesn't cause the program to stop -- this
part seems correct.

But it seems to me that "ignore" should make the "dprintf" not print
anything at all.  Otherwise, what is being ignored?

Hui> +gdb_test "ignore \$bpnum 1" ".*Will ignore next crossing of breakpoint.*"

I was surprised to find that this didn't interfere with the  "info break"
test later on.

Tom