From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string
Date: Mon, 13 May 2013 16:36:00 -0000 [thread overview]
Message-ID: <87bo8edehd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon1MsCu4Abzdh75jB5i-+rXZizYb_Rwx++cnBxzJhV5_Cw@mail.gmail.com> (Hui Zhu's message of "Sat, 11 May 2013 13:54:22 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> + if (aexpr == NULL)
Hui> + error (_("Agent is not support commands of breakpoint %d."),
Hui> + bl->owner->number);
In addition to what Yao said, this change seems roughly equivalent to
simply removing the TRY_CATCH from parse_cmd_to_aexpr. (You'd have to
clear loc->cmd_bytecode first, but it seems to me that this has to be
done anyway, because parse_cmd_to_aexpr can already call error...)
I also still don't understand the code to set null_command_or_parse_error.
Maybe you explained it to me last time, but I forget. If it is actually
correct as-is, I would appreciate a comment explaining it.
Tom
next prev parent reply other threads:[~2013-05-13 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 5:55 Hui Zhu
2013-05-13 7:13 ` Yao Qi
2013-05-13 8:24 ` Hui Zhu
2013-05-13 16:36 ` Tom Tromey [this message]
2013-05-14 11:15 ` Hui Zhu
2013-07-17 20:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo8edehd.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox