From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101440-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16044 invoked by alias); 13 May 2013 16:36:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16030 invoked by uid 89); 13 May 2013 16:36:04 -0000
X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 16:36:02 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4DGa0rN021893	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 13 May 2013 12:36:00 -0400
Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4DGZwgd004102	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 13 May 2013 12:35:59 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string
References: <CANFwon1MsCu4Abzdh75jB5i-+rXZizYb_Rwx++cnBxzJhV5_Cw@mail.gmail.com>
Date: Mon, 13 May 2013 16:36:00 -0000
In-Reply-To: <CANFwon1MsCu4Abzdh75jB5i-+rXZizYb_Rwx++cnBxzJhV5_Cw@mail.gmail.com>	(Hui Zhu's message of "Sat, 11 May 2013 13:54:22 +0800")
Message-ID: <87bo8edehd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00446.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> +	      if (aexpr == NULL)
Hui> +		error (_("Agent is not support commands of breakpoint %d."),
Hui> +		       bl->owner->number);

In addition to what Yao said, this change seems roughly equivalent to
simply removing the TRY_CATCH from parse_cmd_to_aexpr.  (You'd have to
clear loc->cmd_bytecode first, but it seems to me that this has to be
done anyway, because parse_cmd_to_aexpr can already call error...)

I also still don't understand the code to set null_command_or_parse_error.
Maybe you explained it to me last time, but I forget.  If it is actually
correct as-is, I would appreciate a comment explaining it.

Tom