From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [RFA, doc RFA] Fix symtab/15885
Date: Mon, 26 Aug 2013 15:49:00 -0000 [thread overview]
Message-ID: <87bo4k5u5l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <yjt2txifrixw.fsf@ruffy.mtv.corp.google.com> (Doug Evans's message of "Fri, 23 Aug 2013 18:11:55 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> I think there is more cleanup to be had beyond reread_symbols,
Doug> but again I don't want this patch bogged down in that.
More evidence that reread_symbols should go the free_objfile route. I
agree it isn't needed for this fix though.
Doug> + if {[run_on_host "objcopy" [transform objcopy] "--remove-section .gdb_index --add-section .gdb_index=$index_file --set-section-flags .gdb_index=readonly ${program} ${program_with_index}"]} {
This line looks over-long.
Otherwise the patch looks fine to me.
Tom
next prev parent reply other threads:[~2013-08-26 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-24 1:12 Doug Evans
2013-08-24 6:48 ` Eli Zaretskii
2013-08-26 15:49 ` Tom Tromey [this message]
2013-08-26 18:01 ` Doug Evans
2013-08-26 18:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo4k5u5l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox