From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104653-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23716 invoked by alias); 26 Aug 2013 15:49:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23703 invoked by uid 89); 26 Aug 2013 15:49:47 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 15:49:47 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=ALL_TRUSTED,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7QFnh7Z011068	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 26 Aug 2013 11:49:44 -0400
Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7QFngnI019063	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 26 Aug 2013 11:49:43 -0400
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [RFA, doc RFA] Fix symtab/15885
References: <yjt2txifrixw.fsf@ruffy.mtv.corp.google.com>
Date: Mon, 26 Aug 2013 15:49:00 -0000
In-Reply-To: <yjt2txifrixw.fsf@ruffy.mtv.corp.google.com> (Doug Evans's	message of "Fri, 23 Aug 2013 18:11:55 -0700")
Message-ID: <87bo4k5u5l.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-08/txt/msg00747.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I think there is more cleanup to be had beyond reread_symbols,
Doug> but again I don't want this patch bogged down in that.

More evidence that reread_symbols should go the free_objfile route.  I
agree it isn't needed for this fix though.

Doug> +    if {[run_on_host "objcopy" [transform objcopy] "--remove-section .gdb_index --add-section .gdb_index=$index_file --set-section-flags .gdb_index=readonly ${program} ${program_with_index}"]} {

This line looks over-long.

Otherwise the patch looks fine to me.

Tom