From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] fix ref counting of inferior_to_inferior_object
Date: Wed, 25 Sep 2013 20:11:00 -0000 [thread overview]
Message-ID: <87bo3girue.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22QwB7MYkVZCiYijnq7QdJHcjNhkvxbDm5K4FJxMdv3ghw@mail.gmail.com> (Doug Evans's message of "Wed, 25 Sep 2013 12:29:55 -0700")
Doug> Not that you disagree or anything, but IWBN to remove whim from
Doug> the equation. Consistency Is Good, and all that.
I'm not so sure. I think consistency is one good among many, and there
is a cost to enforcing these sorts of rules.
This is particularly true if the code is already not consistent. Unless
maybe you are volunteering to change it all.
Doug> If we're going to store a pointer to the Python object in a gdb
Doug> registry, why not have a convention that gdb owns a reference?
Doug> [could be missing something of course]
I don't think I have an example offhand. I suppose it is potentially a
problem in a case where there are many such objects and we don't want to
retain them all. But those cases are probably rare, maybe non-existent
in the current code. So maybe it is ok.
Tom
next prev parent reply other threads:[~2013-09-25 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 22:27 Doug Evans
2013-09-23 20:41 ` Tom Tromey
2013-09-25 18:18 ` Doug Evans
2013-09-25 18:32 ` Tom Tromey
2013-09-25 19:29 ` Doug Evans
2013-09-25 20:11 ` Tom Tromey [this message]
2013-09-25 21:11 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo3girue.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox