From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] [readline] Fix compilation on MinGW
Date: Tue, 13 Aug 2019 19:46:00 -0000 [thread overview]
Message-ID: <87blwsx305.fsf@tromey.com> (raw)
In-Reply-To: <20190813190436.215693-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 13 Aug 2019 14:04:36 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> S_ISLNK should not be called outside of an #ifdef.
Christian> However, this specific call is actually unnecessary, because
Christian> linkok can only be 0 if S_ISLNK is true, per the code above.
Christian> I have sent a bug report to bug-readline, though it does not show
Christian> up in the online archive yet.
I didn't see it show up there. I wonder if something went wrong.
Christian> 2019-08-13 Christian Biesinger <cbiesinger@google.com>
Christian> * colors.c (_rl_print_color_indicator): Remove unnecessary
Christian> S_ISLNK check to fix compilation on MinGW.
This looks fine to me. Please check it in.
It's important to be sure to follow up with upstream readline; and to
update the patch in the local tree if Chet uses a different patch.
thank you,
Tom
next prev parent reply other threads:[~2019-08-13 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 19:04 Christian Biesinger via gdb-patches
2019-08-13 19:46 ` Tom Tromey [this message]
2019-08-13 19:59 ` Christian Biesinger via gdb-patches
2019-09-15 1:49 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blwsx305.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox