From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130077 invoked by alias); 13 Aug 2019 19:46:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130062 invoked by uid 89); 13 Aug 2019 19:46:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=online X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.194.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 19:46:21 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A55136BFC for ; Tue, 13 Aug 2019 14:46:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xckNhvjdY3Qi0xckNhdhny; Tue, 13 Aug 2019 14:46:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NsM4EzHEd2t6qwTsNsXUSThW8Ojnt6wo1X9e+q9jXUA=; b=xsyArWNgjqRtmSfdf8OSGlRkKH /PAx0U6fdp5u6DVI0UM3WflkkpH7vhWVtM0zl41tmym8CLHXndrhElPeNT4BvgOAM333eE4QefsHa 1grKRxDtkg+N0mhyD5MTX5A9b; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:38020 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hxckN-000t58-C7; Tue, 13 Aug 2019 14:46:19 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] [readline] Fix compilation on MinGW References: <20190813190436.215693-1-cbiesinger@google.com> Date: Tue, 13 Aug 2019 19:46:00 -0000 In-Reply-To: <20190813190436.215693-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 13 Aug 2019 14:04:36 -0500") Message-ID: <87blwsx305.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00275.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> S_ISLNK should not be called outside of an #ifdef. Christian> However, this specific call is actually unnecessary, because Christian> linkok can only be 0 if S_ISLNK is true, per the code above. Christian> I have sent a bug report to bug-readline, though it does not show Christian> up in the online archive yet. I didn't see it show up there. I wonder if something went wrong. Christian> 2019-08-13 Christian Biesinger Christian> * colors.c (_rl_print_color_indicator): Remove unnecessary Christian> S_ISLNK check to fix compilation on MinGW. This looks fine to me. Please check it in. It's important to be sure to follow up with upstream readline; and to update the patch in the local tree if Chet uses a different patch. thank you, Tom