Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix g++ 9.1 build breakage
@ 2019-08-21 20:06 Christian Biesinger via gdb-patches
  2019-08-21 20:08 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2019-08-21 20:06 UTC (permalink / raw)
  To: gdb-patches; +Cc: Christian Biesinger

gdb/ChangeLog:

2019-08-21  Christian Biesinger  <cbiesinger@google.com>

	* tui/tui-data.h (tui_gen_win_info): Add an =default
	move constructor, required by some GCC versions.
---
 gdb/tui/tui-data.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 6dfea41d49..f43035674d 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -55,6 +55,7 @@ protected:
   virtual void make_window ();
 
 public:
+  tui_gen_win_info (tui_gen_win_info &&) = default;
 
   virtual ~tui_gen_win_info ();
 
-- 
2.23.0.rc1.153.gdeed80330f-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix g++ 9.1 build breakage
  2019-08-21 20:06 [PATCH] Fix g++ 9.1 build breakage Christian Biesinger via gdb-patches
@ 2019-08-21 20:08 ` Tom Tromey
  2019-08-21 20:11   ` Christian Biesinger via gdb-patches
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2019-08-21 20:08 UTC (permalink / raw)
  To: Christian Biesinger via gdb-patches; +Cc: Christian Biesinger

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> gdb/ChangeLog:
Christian> 2019-08-21  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* tui/tui-data.h (tui_gen_win_info): Add an =default
Christian> 	move constructor, required by some GCC versions.

Thank you for doing this.  This is ok.

FYI we discussed this on irc and it apparently could only be reproduced
with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix g++ 9.1 build breakage
  2019-08-21 20:08 ` Tom Tromey
@ 2019-08-21 20:11   ` Christian Biesinger via gdb-patches
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2019-08-21 20:11 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Christian Biesinger via gdb-patches

On Wed, Aug 21, 2019 at 3:08 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * tui/tui-data.h (tui_gen_win_info): Add an =default
> Christian>      move constructor, required by some GCC versions.
>
> Thank you for doing this.  This is ok.
>
> FYI we discussed this on irc and it apparently could only be reproduced
> with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Thanks, pushed.

Christian


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-21 20:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 20:06 [PATCH] Fix g++ 9.1 build breakage Christian Biesinger via gdb-patches
2019-08-21 20:08 ` Tom Tromey
2019-08-21 20:11   ` Christian Biesinger via gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox