From: Tom Tromey <tom@tromey.com>
To: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>,
Anton Kolesov <anton.kolesov@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks
Date: Thu, 12 Nov 2020 10:33:48 -0700 [thread overview]
Message-ID: <87blg2eayr.fsf@tromey.com> (raw)
In-Reply-To: <20201112134811.9074-2-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 12 Nov 2020 14:48:10 +0100")
>>>>> "Shahab" == Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> writes:
Shahab> void
Shahab> arc_linux_supply_gregset (const struct regset *regset,
Shahab> struct regcache *regcache,
I was thrown off here. I think I'd normally expect a "gregset" function
to work with an ELF "gregset" -- the entire suite of registers.
Instead this is just an ordinary register callback function.
The patch seems fine to me.
FWIW it seems to me that these functions could all be static.
Tom
next prev parent reply other threads:[~2020-11-12 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:48 [PATCH 0/2] Add native GNU/Linux support for ARC in GDB Shahab Vahedi via Gdb-patches
2020-11-12 13:48 ` [PATCH 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi via Gdb-patches
2020-11-12 17:33 ` Tom Tromey [this message]
2020-11-12 17:36 ` Tom Tromey
2020-11-12 13:48 ` [PATCH 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi via Gdb-patches
2020-11-12 18:03 ` Tom Tromey
2020-12-07 16:37 ` [PATCH v2 0/2] Add native GNU/Linux support for ARC in GDB Shahab Vahedi via Gdb-patches
2020-12-07 16:37 ` [PATCH v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi via Gdb-patches
2020-12-10 19:11 ` Tom Tromey
2020-12-07 16:37 ` [PATCH v2 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi via Gdb-patches
2020-12-10 19:13 ` Tom Tromey
2020-12-10 19:33 ` Shahab Vahedi via Gdb-patches
2020-12-22 11:21 ` [PUSHED v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi via Gdb-patches
2020-12-22 11:21 ` [PUSHED v2 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blg2eayr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=anton.kolesov@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox