From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id I9YPFERyrV83UgAAWB0awg (envelope-from ) for ; Thu, 12 Nov 2020 12:35:00 -0500 Received: by simark.ca (Postfix, from userid 112) id 450B91F08B; Thu, 12 Nov 2020 12:35:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E39611E58E for ; Thu, 12 Nov 2020 12:34:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1069C3896833; Thu, 12 Nov 2020 17:34:59 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.252]) by sourceware.org (Postfix) with ESMTPS id CDD8D3896810 for ; Thu, 12 Nov 2020 17:34:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CDD8D3896810 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 95C861A41 for ; Thu, 12 Nov 2020 11:33:50 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dGTmklX9MiQiZdGTmkVjI4; Thu, 12 Nov 2020 11:33:50 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n2T3eO8rl4joLNZ/4VyHlDQ3CT/ELIXUabSukw1UCAw=; b=qUvyhpWv2/RkRu7aZaHE/fS0uI a1Ld8kjNWUa5kQWPOyd3/Ia8MOBwczleqRjCmV+XfFUr72byj5D0A8o1/67efrJlZIn0pr3vrsLRL 2MuDZ4M/Six0NX4pd4u/tafRh; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:36234 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kdGTm-004FAS-0h; Thu, 12 Nov 2020 10:33:50 -0700 From: Tom Tromey To: Shahab Vahedi via Gdb-patches Subject: Re: [PATCH 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks References: <20201112134811.9074-1-shahab.vahedi@gmail.com> <20201112134811.9074-2-shahab.vahedi@gmail.com> X-Attribution: Tom Date: Thu, 12 Nov 2020 10:33:48 -0700 In-Reply-To: <20201112134811.9074-2-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 12 Nov 2020 14:48:10 +0100") Message-ID: <87blg2eayr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kdGTm-004FAS-0h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:36234 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shahab Vahedi , Shahab Vahedi , Anton Kolesov , Francois Bedard Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Shahab" == Shahab Vahedi via Gdb-patches writes: Shahab> void Shahab> arc_linux_supply_gregset (const struct regset *regset, Shahab> struct regcache *regcache, I was thrown off here. I think I'd normally expect a "gregset" function to work with an ELF "gregset" -- the entire suite of registers. Instead this is just an ordinary register callback function. The patch seems fine to me. FWIW it seems to me that these functions could all be static. Tom