Re: [PATCH 1/3] [gdb/tetsuite] Add missing include in gdb.base/ctf-ptype.c

[Tom Tromey <tom@tromey.com>]

>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:

>> int main ()
>> {
>> -  /* Ensure that malloc is a pointer type; avoid use of "void" and any include files. */
>> -/*  extern char *malloc();*/
>> -

John> This certainly seems curious.  Nothing in the commit log for when this was added
John> gives any clue to why this comment is here, nor why the prototype is commented
John> out.  Other comments later in this function mention limitations of the linker on
John> AIX, which makes me wonder how it was tested originally.  Did you confirm that
John> the test program compiled contained CTF but not DWARF when the test passed?

This file was apparently just copy-pasted from ptype.c, which has this
same commented-out line.  It probably dates to the stabs days.  I
wouldn't worry too much about it... it could use a scrubbing and perhaps
should be moved to gdb.ctf anyway.

Tom