From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XUU1GzDYCmbhER8AWB0awg (envelope-from ) for ; Mon, 01 Apr 2024 11:52:16 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=PMtcdl/7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5DA981E0C0; Mon, 1 Apr 2024 11:52:16 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCCF91E030 for ; Mon, 1 Apr 2024 11:52:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 135DB3858407 for ; Mon, 1 Apr 2024 15:52:13 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 6EA563858D20 for ; Mon, 1 Apr 2024 15:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EA563858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6EA563858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711986702; cv=none; b=e+Xs9D8brDCiPUw0OJwNABxOr3e1njkY3unGXfd1TUicKg2IUPxX+gDEh6DxJn5VkMKPq6oC4JXgyp+6T89LNA6tteTMgADRkB4TgE9BZwz77l8zlLSV4UGTGHmZ4E4u9jiPUGKNK5F72xFjmNZgtfvUSnKqjcR1h83gyAN5yLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711986702; c=relaxed/simple; bh=2Ol4f1MLCUZ8R+Uzv9PcK32CIlbTfITTTqYVb8xeLng=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RARMDlXJ19Q5V5AQHuhVsYtxhUFn/AUhAH+SYNXFTxnKotyoNUgHn/d40wjs1xUOx9GTcO1jFWOUSVUIviF63H5bP50NZOWaf99fbRAWv3TGRBIQTq66qu13ETa4Idirm75FeqqNMI2MMLTEXlHUXQzBVujsMQkHKrm811tivnE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id rJpLrM7tKDI6frJwhrsZmr; Mon, 01 Apr 2024 15:51:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rJukrR7xNiDnerJukrkpdN; Mon, 01 Apr 2024 15:49:38 +0000 X-Authority-Analysis: v=2.4 cv=Cd4O5qrl c=1 sm=1 tr=0 ts=660ad792 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=6I5d2MoRAAAA:8 a=-k8ycitymiJJFKwdRI4A:9 a=zZCYzV9kfG8A:10 a=IjZwj45LgO3ly-622nXo:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j7PDLdbOUy6gwEKj/GI9zp6qTUq8jx+F/uwDQJaV490=; b=PMtcdl/7Hz8gsaWpe+gEtkn+Oj RaMPF6fB+mXyeWmbiqtWqHp9l0HsNpJ0P4E5PE230XjmlWQv+nmX7udeiUOURx4i0TrPbqoquaCce RSRBUWKK3EQIoYMaNLZluWRtT; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:34478 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rrJuj-001GVJ-2R; Mon, 01 Apr 2024 09:49:37 -0600 From: Tom Tromey To: John Baldwin Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] [gdb/tetsuite] Add missing include in gdb.base/ctf-ptype.c References: <20240327143038.20021-1-tdevries@suse.de> <364a5861-a4a2-47ba-9253-5c564c41ebe3@FreeBSD.org> X-Attribution: Tom Date: Mon, 01 Apr 2024 09:49:36 -0600 In-Reply-To: <364a5861-a4a2-47ba-9253-5c564c41ebe3@FreeBSD.org> (John Baldwin's message of "Thu, 28 Mar 2024 13:21:13 -0400") Message-ID: <87bk6taxrj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rrJuj-001GVJ-2R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:34478 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNzVaVo//NC9efmOqQJKFQ2buFtHvkBuwke4/T0ttZ3NBpYjioTlmGvHEs3w8JriruVEHaqaulyXLj8ZvBOhlyBE3PGPDfIlwvqW1D1a7ZPs/aPlOIHD 4+6kEyjJ4TlQwTzCvEawqSlDJPVJWNkB+yr1PFRx9Ri723/NjGSq5+LqWb9qvQ1UeU2CtC9csO4VZeGtyE31bywJHeMpHdR2b9o= X-Spam-Status: No, score=-3015.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "John" == John Baldwin writes: >> int main () >> { >> - /* Ensure that malloc is a pointer type; avoid use of "void" and any include files. */ >> -/* extern char *malloc();*/ >> - John> This certainly seems curious. Nothing in the commit log for when this was added John> gives any clue to why this comment is here, nor why the prototype is commented John> out. Other comments later in this function mention limitations of the linker on John> AIX, which makes me wonder how it was tested originally. Did you confirm that John> the test program compiled contained CTF but not DWARF when the test passed? This file was apparently just copy-pasted from ptype.c, which has this same commented-out line. It probably dates to the stabs days. I wouldn't worry too much about it... it could use a scrubbing and perhaps should be moved to gdb.ctf anyway. Tom