Re: [pushed] gdb: remove O_NOCTTY fallback definitions

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> top.c and inflow.c define O_NOCTTY to 0 if it is not defined.  This is
Simon> unnecessary, since gnulib's fcntl.h already provides the same fallback:

Simon>     ‘O_DSYNC’, ‘O_NOCTTY’, ‘O_NOFOLLOW’, ‘O_RSYNC’, ‘O_SYNC’, and
Simon>     ‘O_TTY_INIT’ are not defined on some platforms. When not otherwise
Simon>     defined, Gnulib defines these macros to 0, which is generally safe.

Simon> Other files use O_NOCTTY without defining the fallback, showing that the
Simon> gnulib fallback works.

Simon> Add fcntl-h to the list of imported gnulib modules, since we now
Simon> explicitly rely on it.  Nothing changes in the import, since that module
Simon> was already imported as a dependency.

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom