From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +R9RGcZX2mpwXwwAWB0awg (envelope-from ) for ; Thu, 22 Oct 2026 14:36:54 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dL2UyRHa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 62D6E378002; Thu, 22 Oct 2026 14:36:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EAEA71E007 for ; Thu, 22 Oct 2026 14:36:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2AFCF4BA2E2A for ; Thu, 22 Oct 2026 18:36:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AFCF4BA2E2A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dL2UyRHa Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id C5BB14BA2E09 for ; Thu, 22 Oct 2026 18:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5BB14BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C5BB14BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792694188; cv=none; b=JNG282Z9B58KYfrybPXFMXP9wppQBtbutIH7PX95KWYtInejgBeU8pMY+O1kfss/xw5TRvv7ubi+p3sHiYQlULIKdmu+kGB2XTu0EGsrIOWHF6C6S3ydnbLBngebegPI/GZI+tUoES11GMN1mD9U7ZGZF5oqpIyGX7hUGkhzq5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792694188; c=relaxed/simple; bh=9WIfz5Cw5NTi6IAQL6fXFiK4utBiXZOrZcJC1ipDAsw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fsPOPU6wSMok8jhdFFp0N573Zw4Favig0fYM+qa3+3/l+s9hl5om4JZnkTZaOmipKqfpNAgszHQ6rVltbS5rnwRcJptReqR0/xcxQh1C7BCuVAqttOT1gbxDqCBCJGi1wq4F5VuTDCzcKYM6jF9s6ytOZ3v177hqNvOJ7or1hyo= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dL2UyRHa reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5BB14BA2E09 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id Ju23xTb5GusRSJxeMxQHqb; Thu, 22 Oct 2026 18:36:26 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JxeKx4APtgNihJxeKxcWSc; Thu, 22 Oct 2026 18:36:24 +0000 X-Authority-Analysis: v=2.4 cv=G78cE8k5 c=1 sm=1 tr=0 ts=6ada57aa a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=tz9FiEeypPtICiMB67YA:9 a=QEXdDO2ut3YA:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y3cW6n5CEtzlS4gthxnQLP2U5oEPq/3krzVZQgIFJJI=; b=dL2UyRHaH599NZFCYp7eid2dpH QJkC3MDXGgJbJJabvaChd3pesCb6kXlZLDxRkQYggS11HVACEvhkjCJ8FG+saObpqWrqwncdIou/E XR4oEOBL3dK56oXqFuV0O8QPz; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:36076 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJxeJ-00000000NHd-3OHp; Thu, 22 Oct 2026 12:36:23 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [pushed] gdb: remove O_NOCTTY fallback definitions In-Reply-To: <20261022165739.232325-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 22 Oct 2026 12:57:37 -0400") References: <20261022165739.232325-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 22 Oct 2026 12:36:22 -0600 Message-ID: <87bj8lshuh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJxeJ-00000000NHd-3OHp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:36076 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBqEl8ix29oIQtlddSrMHEZOEDzg1NqY2KwTMF3pt0vYeBWP2rs5awgawy04cocrKNeLUmnmZ+xfNZ52VYRuB872RnkM+WfrPPPhC2vNdZAn8t3IU/zZ /RGwLIPctIKwOV6m0hI+mcJCg3Bw1rsWTdcNxPHxcOn/3jGYUfh7W5rmMxHbwc9jvqkvR+1jaIrvtYdbN3yxFZElFE+E34qLgHM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" =3D=3D Simon Marchi writes: Simon> top.c and inflow.c define O_NOCTTY to 0 if it is not defined. This = is Simon> unnecessary, since gnulib's fcntl.h already provides the same fallba= ck: Simon> =E2=80=98O_DSYNC=E2=80=99, =E2=80=98O_NOCTTY=E2=80=99, =E2=80=98= O_NOFOLLOW=E2=80=99, =E2=80=98O_RSYNC=E2=80=99, =E2=80=98O_SYNC=E2=80=99, a= nd Simon> =E2=80=98O_TTY_INIT=E2=80=99 are not defined on some platforms. = When not otherwise Simon> defined, Gnulib defines these macros to 0, which is generally sa= fe. Simon> Other files use O_NOCTTY without defining the fallback, showing that= the Simon> gnulib fallback works. Simon> Add fcntl-h to the list of imported gnulib modules, since we now Simon> explicitly rely on it. Nothing changes in the import, since that mo= dule Simon> was already imported as a dependency. Thanks. Approved-By: Tom Tromey Tom