From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Add missing gdb_bfd.h includes
Date: Wed, 26 Sep 2012 20:01:00 -0000 [thread overview]
Message-ID: <87a9wcy2no.fsf@fleche.redhat.com> (raw)
In-Reply-To: <18620.4427075156$1348564388@news.gmane.org> (Pierre Muller's message of "Tue, 25 Sep 2012 11:12:32 +0200")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> Is this OK?
Yes, thank you.
Pierre> As usual,
Pierre> 1) I am not sure about correct wording for ChangeLog
What you wrote is fine.
Pierre> 2) I never really understood the ordering logic (or to
Pierre> be more precise, if there is an ordering logic) of C headers
Pierre> in C source files, thus I inserted them more or less randomly...
There should not be many strong ordering dependencies in gdb, aside from
the rule that defs.h has to come first. I wouldn't worry about it in
general.
Tom
next parent reply other threads:[~2012-09-26 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18620.4427075156$1348564388@news.gmane.org>
2012-09-26 20:01 ` Tom Tromey [this message]
2012-09-26 21:31 ` Pierre Muller
2012-09-25 9:12 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9wcy2no.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox